Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

check before use daemon->shm_info #1229

Merged
merged 1 commit into from
Jan 21, 2025
Merged

check before use daemon->shm_info #1229

merged 1 commit into from
Jan 21, 2025

Conversation

eaglegai
Copy link
Contributor

fix coredump after the command unbound-control stop unbound

fix: #1228

@eaglegai
check before use daemon->shm_info
0634c1e 
fix core after the command `unbound-control stop unbound`

fix:NLnetLabs#1228
Signed-off-by: eaglegai <[email protected]>
wcawijngaards
wcawijngaards approved these changes Jan 21, 2025
View reviewed changes
Copy link
Member

@wcawijngaards wcawijngaards left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The change looks good. Prevents failure when shminfo was not allocated.

@wcawijngaards wcawijngaards merged commit 073c730 into NLnetLabs:master Jan 21, 2025
1 check passed
wcawijngaards added a commit that referenced this pull request Jan 21, 2025
@wcawijngaards
Changelog note for #1229
d9b863e 
- Merge #1229: check before use daemon->shm_info.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@wcawijngaards wcawijngaards wcawijngaards approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

coredump after command unbound-control stop unbound
2 participants
@eaglegai @wcawijngaards