Fix chroot manpage description #1170
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
gthess
requested changes
Nov 1, 2024
There was a problem hiding this comment.
Thanks! The sentence does read more clearly.
But I would leave the doc/Changelog edit out. We update it ourselves when we merge code. We ofcourse attribute the change there and will use the real name if available or username if not. If you have a preference let me know btw.
|
Done |
gthess
approved these changes
Nov 1, 2024
gthess
added a commit
that referenced
this pull request
Nov 1, 2024
- Merge #1170 from Melroy van den Berg, Fix chroot manpage description.
|
(The online documentation is synced when a new version is released) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Rephrase the man page sentence about what the default chroot is set to, which could also be set to: "" by default. In some distributions like Ubuntu and Fedora this is set to "", which means by default disabled.
So you can't say chroot is enabled by default, since that is not always the case.
Fixes: #1164