Only check old pid if no username #1078
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Do as the comment says and only check old pid if there is no username configured.
wcawijngaards
approved these changes
May 29, 2024
wcawijngaards
added a commit
that referenced
this pull request
May 29, 2024
- Merge #1078: Only check old pid if no username.
|
Thank you for the fix! The comment was correct and indicates what should happen, the bugfix helps detect past failures. |
jedisct1
added a commit
to jedisct1/unbound
that referenced
this pull request
Jun 16, 2024
* nlnet/master: (35 commits) - Add unit test for validation of repeated use of a DNAME record. - Fix validation for repeated use of a DNAME record. - Fix typos for 'the the' in text. - Fix memory leak in setup of dsa sig. - Skip unbound-dnstap-socket unit test when not compiled with --enable-debug. - Fix to squelch connection reset by peer errors from log. And fix that the tcp read errors are labeled as initial for the first calls. - Fix memory leak on exit for unbound-dnstap-socket; creates false negatives during testing. - Fix memory leak when reload_keep_cache is used and num-threads changes. - Enable AddressSanitizer error detection in tdir tests. - Fix for NLnetLabs#1079: fix RPZ taglist in iterator callback that no client info is like no taglist intersection. - Fix NLnetLabs#1079: tags from tagged rpz zones are no longer honored after upgrade from 1.19.3 to 1.20.0. Changelog note for NLnetLabs#1078. - Merge NLnetLabs#1078: Only check old pid if no username. Only check old pid if no username - Update patch to remove 'command' shell builtin and update error text. unbound-control-setup: check openssl - Fix unused variable warning on compilation with no thread support. - Fix spelling of tcp-idle-timeout docs, from Michael Tokarev. - Fix to enable that SERVFAIL is cached, for a short period, for more cases. In the cases where limits are exceeded. Changelog entry for NLnetLabs#1059: - Fix NLnetLabs#1059: Intermittent DNS blocking failure with local-zone and always_nxdomain. Addition of local_zones dynamically via unbound-control was not finding the zone's parent correctly. Proper parent identification for dynamically entered local zones (NLnetLabs#1076) ...
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Do as the comment says and only check old pid if there is no username configured.