Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Unify the RPZ log messages #630

Closed
pettai opened this issue Feb 15, 2022 · 1 comment
Closed

Unify the RPZ log messages #630

pettai opened this issue Feb 15, 2022 · 1 comment
Assignees
@gthess

Comments

@pettai
Copy link
Contributor

pettai commented Feb 15, 2022

Describe the bug
Very remotely related is a nit to #628

First hit on the QNAME log says "rpz: applied ..."
https://github.com/NLnetLabs/unbound/blob/master/services/rpz.c#L1405
While the response IP hit log says "RPZ applied ..."
https://github.com/NLnetLabs/unbound/blob/master/respip/respip.c#L1304

To reproduce
Compare QNAME and Response IP RPZ hit logs (example here)
#628

Expected behavior
Log uniformly "rpz: ..."

System:

  • Unbound version: 1.15.0
  • OS: Ubuntu
  • unbound -V output:
@gthess gthess closed this as completed in 82adcfb Feb 28, 2022
@gthess gthess mentioned this issue Feb 28, 2022
Closed
@gthess
Copy link
Member

gthess commented Feb 28, 2022

"rpz:" was chosen for solving this.

@gthess gthess self-assigned this Feb 28, 2022
jedisct1 added a commit to jedisct1/unbound that referenced this issue Mar 14, 2022
@jedisct1
Merge remote-tracking branch 'nlnet/master'
c5ad632 
* nlnet/master: (27 commits)
  Changelog note for NLnetLabs#644, move commands together for library binary.
  Make `install-lib` make target install the pkg-config file.
  - Fix configure for python to use sysutils, because distutils is   deprecated. It uses sysutils when available, distutils otherwise.
  - Fix for NLnetLabs#637: fix integer overflow checks in sldns_str2period.
  - Fix NLnetLabs#637: Integer Overflow in sldns_str2period function.
  - Fix compile warnings for printf ll format on mingw compile.
  - Various fixes for NLnetLabs#632: variable initialisation, convert the qinfo   to str once, accept trailing dot in the local-zone ipset option.
  Changelog entry for NLnetLabs#632 - Merge PR NLnetLabs#632 from scottrw93: Match cnames in ipset.
  - Added tests for ipset.
  - Fix pythonmod for change in iter_dp_is_useless function prototype.
  - Fix for edns client subnet option add fix in removal code, from review.
  - Fix edns client subnet to add the option based on the option list,   so that it is not state dependent, after the state fix of NLnetLabs#605 for   double EDNS options.
  Changelog entry for NLnetLabs#623: - Merge NLnetLabs#623 from rex4539: Fix typos.
  - Fix NLnetLabs#630: Unify the RPZ log messages.
  - Fix for NLnetLabs#633: updated fix with new text.
  - Fix NLnetLabs#633: Document unix domain socket support for unbound-control.
  - Fix check interface existence for support detection in remote lookup.
  - update Makefile dependencies.
  - Fix to detect that no IPv6 support means that IPv6 addresses are   useless for delegation point lookups.
  Match cnames in ipset
  ...
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@gthess gthess

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@pettai @gthess