- Fix for edns client subnet option add fix in removal code, from rev…

…iew.
NLnetLabs · Feb 28, 2022 · 7749d98 · 7749d98
1 parent 8e8ccfe
commit 7749d98
Show file tree

Hide file tree

Showing 2 changed files with 2 additions and 1 deletion.
diff --git a/doc/Changelog b/doc/Changelog
@@ -8,6 +8,7 @@
 	- Fix edns client subnet to add the option based on the option list,
 	  so that it is not state dependent, after the state fix of #605 for
 	  double EDNS options.
+	- Fix for edns client subnet option add fix in removal code, from review.
 
 25 February 2022: Wouter
 	- Fix to detect that no IPv6 support means that IPv6 addresses are

diff --git a/edns-subnet/subnetmod.c b/edns-subnet/subnetmod.c
@@ -172,7 +172,7 @@ int ecs_whitelist_check(struct query_info* qinfo,
 	else {
 		/* Outgoing ECS option is set, but we don't want to sent it to
 		 * this address, remove option. */
-		if(!edns_opt_list_find(qstate->edns_opts_back_out,
+		if(edns_opt_list_find(qstate->edns_opts_back_out,
 			qstate->env->cfg->client_subnet_opcode)) {
 			edns_opt_list_remove(&qstate->edns_opts_back_out,
 				qstate->env->cfg->client_subnet_opcode);