Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix broken links #413

Merged
merged 3 commits into from
Dec 10, 2024
Merged

Fix broken links #413

merged 3 commits into from
Dec 10, 2024

Conversation

egpbos
Copy link
Member

@egpbos egpbos commented Dec 7, 2024

Changes in this PR

Ignores Posit documentation URLs from CI (they seem to get blocked from GitHub CI) and updates some outdated links in the GPU chapter.

Fixes #358.

Fixes #355.

It gives a 403 forbidden when accessed from GitHub CI. GitHub is probably blacklisted by Posit servers, so no point checking them.
They seem to also get blocked, 403, just like Posit links.
@maltelueken
Copy link
Member

Looks good from my side! (Not sure why the pre-commit action is failing?)

@egpbos
Copy link
Member Author

egpbos commented Dec 10, 2024

Thanks @maltelueken! The pre-commit was activated on the repo, but the configuration file still has to be added, which will happen in #406 :) Should work again after that's merged.

@isazi let me know if you strongly disagree with this solution, we'll get it unmerged asap (sorry, want to rush this a bit, because of the upcoming release).

@egpbos egpbos merged commit 7d20e8f into main Dec 10, 2024
2 of 3 checks passed
@egpbos egpbos deleted the broken_links_v1.0 branch December 10, 2024 15:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Broken link in R chapter Broken links in GPU chapter
2 participants