Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove unambiguous complex assertions #194

Merged
merged 10 commits into from
Apr 7, 2022
Merged

Remove unambiguous complex assertions #194

merged 10 commits into from
Apr 7, 2022

Conversation

georgeyiasemis
Copy link
Contributor

@georgeyiasemis georgeyiasemis commented Apr 6, 2022 •
edited
Loading

Main changes:

  • assert_complex(shape, complex_last) --> assert_complex(shape, complex_axis, complex_last=None)
  • modulus_if_complex removed
  • modulus need to specify axis
  • MRIModelEngine cropper expect the modulus of predicted data

@github-actions github-actions bot added the python label Apr 6, 2022
@codecov
Copy link

codecov bot commented Apr 6, 2022 •
edited
Loading

Codecov Report

Merging #194 (7fa97de) into main (6308635) will decrease coverage by 0.75%.
The diff coverage is 100.00%.

@@            Coverage Diff             @@
##             main     #194      +/-   ##
==========================================
- Coverage   76.53%   75.78%   -0.76%     
==========================================
  Files          71       71              
  Lines        5430     5100     -330     
==========================================
- Hits         4156     3865     -291     
+ Misses       1274     1235      -39
Impacted Files Coverage Δ
direct/engine.py 75.29% <ø> (ø)
direct/data/transforms.py 94.38% <100.00%> (-0.46%) ⬇️
direct/nn/mri_models.py 93.67% <100.00%> (-2.31%) ⬇️
direct/nn/rim/rim_engine.py 91.80% <100.00%> (-0.34%) ⬇️
direct/utils/__init__.py 65.30% <100.00%> (-2.53%) ⬇️
direct/utils/asserts.py 80.95% <100.00%> (+2.69%) ⬆️
... and 1 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 6308635...7fa97de. Read the comment docs.

@georgeyiasemis georgeyiasemis changed the title Remove ambiguous complex assertions Remove unambiguous complex assertions Apr 6, 2022
@jonasteuwen jonasteuwen merged commit 31eac22 into main Apr 7, 2022
@jonasteuwen jonasteuwen deleted the remove-complex-assertions branch April 7, 2022 08:19
georgeyiasemis added a commit that referenced this pull request Apr 8, 2022
@georgeyiasemis
Remove unambiguous complex assertions (#194) (#195)
9b1fd36 
* `assert_complex(shape, complex_last)` --> `assert_complex(shape, complex_axis, complex_last=None)`
* `modulus_if_complex` removed
* `modulus` need to specify axis
* `MRIModelEngine` cropper expect the modulus of predicted data
jonasteuwen pushed a commit that referenced this pull request Apr 19, 2022
@georgeyiasemis
Code quality (#196)
bceae48 
* Remove  unambiguous complex assertions (#194) (#195)
* Improve typing
* `modulus_if_complex` removed, `modulus` needs to specify axis.
* `modulus` need to specify axis
* Improve documentation and `README.rst`
* Added tests
* Add end-to-end tests
* Several bug fixes

Co-authored-by: George Yiasemis <georgeyiasemis.hotmail.com>
This was referenced Jun 1, 2022
Merged
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jonasteuwen jonasteuwen Awaiting requested review from jonasteuwen

Assignees
No one assigned
Labels
python
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@georgeyiasemis @jonasteuwen