Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bug fix for NAG compiler issue in FatesHydroWTFMod #791

Merged
merged 1 commit into from
Oct 12, 2021

Conversation

glemieux
Copy link
Contributor

@glemieux glemieux commented Oct 6, 2021

Description:

This bugfix PR updates the psi_eff calculation to avoid an NAG compiler arithmetic exception error when a negative zero is raise to a power. This PR resolves #790.

Collaborators:

@rgknox

Expectation of Answer Changes:

Only when running in FatesHydro mode

Checklist:

  • My change requires a change to the documentation.
  • I have updated the in-code documentation .AND. (the technical note .OR. the wiki) accordingly.
  • I have read the CONTRIBUTING document.
  • FATES PASS/FAIL regression tests were run
  • If answers were expected to change, evaluation was performed and provided

Test Results:

CTSM (or) E3SM (specify which) test hash-tag:

CTSM (or) E3SM (specify which) baseline hash-tag:

FATES baseline hash-tag:

Test Output:

@glemieux glemieux added bug - software engineering PR status: Not Ready The author is signaling that this PR is a work in progress and not ready for integration. labels Oct 6, 2021
@glemieux glemieux changed the title Bug fix for issue NAG compiler issue in FatesHydroWTFMod Bug fix for NAG compiler issue in FatesHydroWTFMod Oct 6, 2021
@rgknox
Copy link
Contributor

rgknox commented Oct 6, 2021

@glemieux why is there so much whitespace change? Was that intentional?

@glemieux
Copy link
Contributor Author

glemieux commented Oct 6, 2021

@rgknox it wasn't intentional. One of the recent VSCode update changed something in one of the settings and now it auto-deletes trailing whitespace for what ever file I touch during commit. It's annoying; I need to track down the setting sometime soon to turn it off.

@glemieux glemieux marked this pull request as ready for review October 6, 2021 19:08
@ekluzek
Copy link
Collaborator

ekluzek commented Oct 6, 2021

I do like the idea of getting rid of trailing whitespace. But, agree you want that to happen thoughtfully, and hopefully just in a commit that does that one thing. When you look at the PR you can turn off whitespace changes so that does help, or use "-w -b" to do it on the command line.

@rgknox
Copy link
Contributor

rgknox commented Oct 7, 2021

I'm only concerned because we have several PRs currently out that change that module. I want to avoid conflicts and confusion with merges

@glemieux glemieux removed the PR status: Not Ready The author is signaling that this PR is a work in progress and not ready for integration. label Oct 7, 2021
@rgknox rgknox self-requested a review October 11, 2021 01:38
@rgknox
Copy link
Contributor

rgknox commented Oct 12, 2021

tests pass w/ expected fails:
/glade/scratch/rgknox/tests_1012-113133ch

@rgknox rgknox merged commit 2fa452a into NGEET:master Oct 12, 2021
@glemieux glemieux deleted the nag_arithmetic_exp-fix branch November 16, 2022 00:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

NAG compiler runtime error in FatesHydroWTFMod
3 participants