Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add resolution-related terms and definitions #134

Merged
merged 23 commits into from
Sep 16, 2024

Conversation

Zack-83
Copy link
Collaborator

@Zack-83 Zack-83 commented Aug 8, 2024

Closed #125

@Zack-83 Zack-83 linked an issue Aug 8, 2024 that may be closed by this pull request
Copy link
Member

@StroemPhi StroemPhi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Again many thanks!

@StroemPhi
Copy link
Member

@Zack-83 I've linked to the terms in the CHARISMA wiki that you provided in the issue, apart from the Pixel resolution , since we didn't define it here. Should we, or can we ignore it?
If we should also define it, then I propose opening a new PR for it, so we can merge this one.

@Zack-83
Copy link
Collaborator Author

Zack-83 commented Sep 16, 2024

@Zack-83 I've linked to the terms in the CHARISMA wiki that you provided in the issue, apart from the Pixel resolution , since we didn't define it here. Should we, or can we ignore it? If we should also define it, then I propose opening a new PR for it, so we can merge this one.

Clearly the definition of "image resolution" (~ NUMBER of distinct neighbouring measurements) is not coherent with the definitions of "optical resolution" (~ DISTANCE between neighbouring measurement values) considered in the present PR. Therefore I agree with you to leave this term out.

@StroemPhi StroemPhi merged commit 7f98add into main Sep 16, 2024
1 check passed
@StroemPhi StroemPhi deleted the 125-ntr-add-resolution-definitions branch September 16, 2024 08:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[NTR] Add resolution definitions
2 participants