Share current view of map via URL search params #2437

ianguerin · 2024-06-07T01:25:56Z

Includes heading, pitch, roll, latitude, longitude, height, and enabled layers.
Add feature behind Map config showShareUrl.

QuickDemoShareViewToURL.webm

#1806

github-actions · 2024-06-10T16:18:08Z

src/js/views/portals/PortalView.js

+              this.model.get("name") +
+              " " +
+              MetacatUI.appModel.get("portalTermSingular") +
+              " can be viewed in the ",


[prettier] _{reported by reviewdog 🐶}

Suggested change

this.model.get("name") +

" " +

MetacatUI.appModel.get("portalTermSingular") +

" can be viewed in the ",

this.model.get("name") +

" " +

MetacatUI.appModel.get("portalTermSingular") +

" can be viewed in the ",

github-actions · 2024-06-10T16:18:08Z

src/js/views/portals/PortalView.js

+              "#portal-section-tabs",
+            ),


[prettier] _{reported by reviewdog 🐶}

Suggested change

"#portal-section-tabs",

),

"#portal-section-tabs",

),

github-actions · 2024-06-10T16:18:08Z

src/js/views/portals/PortalView.js

@@ -533,7 +535,7 @@ define([
        } catch (error) {
          console.log(
            "Error re-arranging tabs according to the pageOrder option. Error message: " +
-              error,
+            error,


[prettier] _{reported by reviewdog 🐶}

Suggested change

error,

error,

github-actions · 2024-06-10T16:18:08Z

src/js/views/portals/PortalView.js

+              MetacatUI.root +
+              "/css/portal-layouts/" +
+              layout +
+              ".css",


[prettier] _{reported by reviewdog 🐶}

Suggested change

MetacatUI.root +

"/css/portal-layouts/" +

layout +

".css",

MetacatUI.root +

"/css/portal-layouts/" +

layout +

".css",

github-actions · 2024-06-10T16:18:08Z

src/js/views/portals/PortalView.js

+            ". Error details: " +
+            error,


[prettier] _{reported by reviewdog 🐶}

Suggested change

". Error details: " +

error,

". Error details: " +

error,

github-actions · 2024-06-10T16:18:08Z

src/js/views/portals/PortalView.js

+            //If the request to the monitor/status API fails, then show the not-found message
+            view.showNotFound.call(view);
+          },


[prettier] _{reported by reviewdog 🐶}

Suggested change

//If the request to the monitor/status API fails, then show the not-found message

view.showNotFound.call(view);

},

//If the request to the monitor/status API fails, then show the not-found message

view.showNotFound.call(view);

},

github-actions · 2024-06-10T16:18:08Z

src/js/views/portals/PortalView.js

+                  "\".</p><p><i class='icon icon-exclamation-sign'></i> If this portal was created in the last few minutes, it may still be processing, since there are currently <b>" +
+                  sizeOfQueue +
+                  "</b> submissions in the queue.</p>",


[prettier] _{reported by reviewdog 🐶}

Suggested change

"\". If this portal was created in the last few minutes, it may still be processing, since there are currently " +

sizeOfQueue +

" submissions in the queue.",

"\". If this portal was created in the last few minutes, it may still be processing, since there are currently " +

sizeOfQueue +

" submissions in the queue.",

github-actions · 2024-06-10T16:18:09Z

src/js/views/portals/PortalView.js

+          "The data portal \"<span id='portal-view-not-found-name'></span>" +
+          "\" doesn't exist.",


[prettier] _{reported by reviewdog 🐶}

Suggested change

"The data portal \"" +

"\" doesn't exist.",

"The data portal \"" +

"\" doesn't exist.",

github-actions · 2024-06-10T16:18:09Z

src/js/views/portals/PortalView.js

+            icon +
+            "'></i>" +
+            errorTitle +
+            "</h4>" +
+            errorMsg,


[prettier] _{reported by reviewdog 🐶}

Suggested change

icon +

"'>" +

errorTitle +

"</h4>" +

errorMsg,

icon +

"'>" +

errorTitle +

"</h4>" +

errorMsg,

github-actions · 2024-06-10T16:18:09Z

src/js/views/portals/PortalView.js

@@ -1111,19 +1119,19 @@ define([
        } catch (error) {
          console.log(
            "There was a problem trying to display the error message in the Portal View. Error details: " +
-              error,
+            error,


[prettier] _{reported by reviewdog 🐶}

Suggested change

error,

error,

CONTRIBUTING.md

yvonnesjy

Have we tested this on a main repo map?

CONTRIBUTING.md

src/css/map-view.css

src/js/common/SearchParams.js

src/js/views/maps/CesiumWidgetView.js

src/js/views/maps/ToolbarView.js

src/js/views/portals/PortalView.js

src/js/models/maps/assets/MapAsset.js

src/js/views/maps/CesiumWidgetView.js

src/js/views/maps/ToolbarView.js

src/js/views/portals/PortalView.js

yvonnesjy · 2024-06-15T00:16:59Z

Have we tested this on a main repo map?

Tested on ADC and it works! The map is too skinny in the 3-part view though so the copy button is not shown immediately. Can we make clicking on the input box a copy action as well?

robyngit

This works so well @ianguerin, people are going to be really excited about this!

Approved pending changes @yvonnesjy requested

robyngit · 2024-06-07T14:44:53Z

src/js/models/maps/Map.js

+          // TODO(ianguerin): make this false before checking in.
+          showShareUrl: true,


Suggested change

// TODO(ianguerin): make this false before checking in.

showShareUrl: true,

showShareUrl: false,

ianguerin · 2024-06-17T16:33:19Z

Have we tested this on a main repo map?

Tested on ADC and it works! The map is too skinny in the 3-part view though so the copy button is not shown immediately. Can we make clicking on the input box a copy action as well?

I've added the ability to copy by clicking the input

Includes heading, pitch, roll, latitude, longitude, height, and enabled layers. Add feature behind Map config showShareUrl.

…be properly set when switching between tabs in a PortalView

robyngit linked an issue Jun 7, 2024 that may be closed by this pull request

Save the current Cesium config as a link for sharing #1806

Closed

ianguerin force-pushed the feature-1806-save-to-url branch from fe03591 to b121572 Compare June 10, 2024 16:17

github-actions bot reviewed Jun 10, 2024

View reviewed changes

ianguerin force-pushed the feature-1806-save-to-url branch from b121572 to b817596 Compare June 10, 2024 16:34

ianguerin commented Jun 10, 2024

View reviewed changes

CONTRIBUTING.md Show resolved Hide resolved

ianguerin requested review from yvonnesjy and robyngit June 10, 2024 16:36

ianguerin mentioned this pull request Jun 10, 2024

Portal Theme: Remove semantic color variables #2436

Merged

yvonnesjy requested changes Jun 11, 2024

View reviewed changes

ianguerin force-pushed the feature-1806-save-to-url branch 2 times, most recently from 05a6e43 to e3e2132 Compare June 14, 2024 19:45

ianguerin requested a review from yvonnesjy June 14, 2024 19:52

yvonnesjy reviewed Jun 14, 2024

View reviewed changes

robyngit approved these changes Jun 17, 2024

View reviewed changes

ianguerin requested a review from yvonnesjy June 18, 2024 18:14

ianguerin added 9 commits June 18, 2024 11:22

Share current view of map via URL search params

83f35d2

Includes heading, pitch, roll, latitude, longitude, height, and enabled layers. Add feature behind Map config showShareUrl.

Fixup: Address pr comments and lint issues

31e04bf

Fixup: Remove query parameters when navigating between tabs in a portal

ba114e1

Fixup: Fix broken tests

12d9823

Fixup: Alert viz section when it becomes active so search params can …

f551fb3

…be properly set when switching between tabs in a PortalView

Fixup: Update css variable names after rebase

120f14e

Fixup: Address PR comments on checking for existing ShareUrlView

b4b6665

Fixup: Unit test for clicking input

88a6e03

Fixup: Rebase new changes from develop, fix broken unit tests

844a1a6

ianguerin force-pushed the feature-1806-save-to-url branch from 7ed0a42 to 844a1a6 Compare June 18, 2024 18:57

yvonnesjy approved these changes Jun 18, 2024

View reviewed changes

ianguerin merged commit fd5daaf into develop Jun 18, 2024
1 check failed

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Share current view of map via URL search params #2437

Share current view of map via URL search params #2437

ianguerin commented Jun 7, 2024 •

edited

Loading

github-actions bot Jun 10, 2024

github-actions bot Jun 10, 2024

github-actions bot Jun 10, 2024

github-actions bot Jun 10, 2024

github-actions bot Jun 10, 2024

github-actions bot Jun 10, 2024

github-actions bot Jun 10, 2024

github-actions bot Jun 10, 2024

github-actions bot Jun 10, 2024

github-actions bot Jun 10, 2024

yvonnesjy left a comment

yvonnesjy commented Jun 15, 2024 •

edited

Loading

robyngit left a comment

robyngit Jun 7, 2024

ianguerin commented Jun 17, 2024

		"The data portal \"<span id='portal-view-not-found-name'></span>" +
		"\" doesn't exist.",

		// TODO(ianguerin): make this false before checking in.
		showShareUrl: true,

	// TODO(ianguerin): make this false before checking in.
	showShareUrl: true,
	showShareUrl: false,

Share current view of map via URL search params #2437

Share current view of map via URL search params #2437

Conversation

ianguerin commented Jun 7, 2024 • edited Loading

github-actions bot Jun 10, 2024

Choose a reason for hiding this comment

github-actions bot Jun 10, 2024

Choose a reason for hiding this comment

github-actions bot Jun 10, 2024

Choose a reason for hiding this comment

github-actions bot Jun 10, 2024

Choose a reason for hiding this comment

github-actions bot Jun 10, 2024

Choose a reason for hiding this comment

github-actions bot Jun 10, 2024

Choose a reason for hiding this comment

github-actions bot Jun 10, 2024

Choose a reason for hiding this comment

github-actions bot Jun 10, 2024

Choose a reason for hiding this comment

github-actions bot Jun 10, 2024

Choose a reason for hiding this comment

github-actions bot Jun 10, 2024

Choose a reason for hiding this comment

yvonnesjy left a comment

Choose a reason for hiding this comment

yvonnesjy commented Jun 15, 2024 • edited Loading

robyngit left a comment

Choose a reason for hiding this comment

robyngit Jun 7, 2024

Choose a reason for hiding this comment

ianguerin commented Jun 17, 2024

ianguerin commented Jun 7, 2024 •

edited

Loading

yvonnesjy commented Jun 15, 2024 •

edited

Loading