-
Notifications
You must be signed in to change notification settings - Fork 11
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Introduction of aggregation datasets #320
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks all good, with sufficient testing and docs updates. I've raised only minor comments (mostly typos). Once you've considered these, please feel free to merge.
Even more than I usually make, but it is a long PR :) Co-authored-by: Sadie L. Bartholomew <[email protected]>
Co-authored-by: Sadie L. Bartholomew <[email protected]>
Co-authored-by: Sadie L. Bartholomew <[email protected]>
Co-authored-by: Sadie L. Bartholomew <[email protected]>
Co-authored-by: Sadie L. Bartholomew <[email protected]>
Co-authored-by: Sadie L. Bartholomew <[email protected]>
Co-authored-by: Sadie L. Bartholomew <[email protected]>
Co-authored-by: Sadie L. Bartholomew <[email protected]>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for responding to the minor feedback items. Everything seems to be covered now. I've done a final sanity check and all is good, except for a few new typos introduced, as raised in-line. Please blitz those and then we can merge.
Co-authored-by: Sadie L. Bartholomew <[email protected]>
Thanks for all the improvements, Sadie! merging now ... |
Fixes #319
Moves CFA functionality from cf-python to cfdm
I think fairly self explanatory (let me know if otherwise :)), but some points of note:
read.py
is refactored as a class so that upstream applications (e.g. cf-python) can avoid large amounts of docstring and code duplicationArray
objects has been changed for similar reasons. This includes moving the old FileArrayMixin to a the abstractFileArray