Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Introduction of aggregation datasets #320

Merged
merged 156 commits into from
Feb 17, 2025
Merged

Conversation

davidhassell
Copy link
Contributor

Fixes #319

Moves CFA functionality from cf-python to cfdm

I think fairly self explanatory (let me know if otherwise :)), but some points of note:

  • CFA API is updated a bit to reflect that which is (currently) going through discussion over at the CF conventions
  • read.py is refactored as a class so that upstream applications (e.g. cf-python) can avoid large amounts of docstring and code duplication
  • The inheritance structure of Array objects has been changed for similar reasons. This includes moving the old FileArrayMixin to a the abstract FileArray

Copy link
Member

@sadielbartholomew sadielbartholomew left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks all good, with sufficient testing and docs updates. I've raised only minor comments (mostly typos). Once you've considered these, please feel free to merge.

Copy link
Member

@sadielbartholomew sadielbartholomew left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for responding to the minor feedback items. Everything seems to be covered now. I've done a final sanity check and all is good, except for a few new typos introduced, as raised in-line. Please blitz those and then we can merge.

davidhassell and others added 2 commits February 17, 2025 10:22
Co-authored-by: Sadie L. Bartholomew <[email protected]>
@davidhassell
Copy link
Contributor Author

Thanks for all the improvements, Sadie! merging now ...

@davidhassell davidhassell merged commit 4020c84 into NCAS-CMS:main Feb 17, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Introduce reading and writing of aggregation datasets (introduced at CF-1.13)
2 participants