Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

del_properties methods, and ignore_properties keyword to cf.unique_constructs #241

Merged
merged 15 commits into from
Feb 27, 2023

Conversation

davidhassell
Copy link
Contributor

Fixes #240

@davidhassell davidhassell added this to the Next release milestone Feb 14, 2023
@codecov
Copy link

codecov bot commented Feb 14, 2023

Codecov Report

Merging #241 (ed8d6ca) into main (0cece5a) will increase coverage by 0.03%.
The diff coverage is 100.00%.

❗ Current head ed8d6ca differs from pull request most recent head 43680e5. Consider uploading reports for the commit 43680e5 to get more accurate results

@@            Coverage Diff             @@
##             main     #241      +/-   ##
==========================================
+ Coverage   87.50%   87.52%   +0.03%     
==========================================
  Files         124      124              
  Lines       12740    12764      +24     
==========================================
+ Hits        11147    11171      +24     
  Misses       1593     1593              
Flag Coverage Δ
unittests 87.52% <100.00%> (+0.03%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
cfdm/core/abstract/properties.py 100.00% <100.00%> (+2.13%) ⬆️
cfdm/functions.py 95.98% <100.00%> (+0.22%) ⬆️
cfdm/read_write/netcdf/netcdfread.py 83.88% <0.00%> (-0.04%) ⬇️

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

@sadielbartholomew
Copy link
Member

Hi David, since you haven't merged are you wanting and awaiting a review on this, and then for NCAS-CMS/cf-python#598 too? If so I will assign myself and get it done shortly.

@davidhassell
Copy link
Contributor Author

Hi Sadie - thanks for asking, but I think it's best to hold off for now, as it turns out Grenville is still testing it. I'll request the review formally when he's done (in a week or two?).

@sadielbartholomew
Copy link
Member

Oh sure, I wasn't aware of that so thanks for the clarification. I'll wait until it pops up in my notifications.

@davidhassell
Copy link
Contributor Author

Ready now - sooner than expected. See also NCAS-CMS/cf-python#598.

Copy link
Member

@sadielbartholomew sadielbartholomew left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Some minor comments raised, but otherwise all good, with the new testing nice and thorough. Please merge when ready.


If *ignore_properties* has been set then *copy* is ignored
and deep copies are always returned, even if
*ignore_properties* is an empty sequence.
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

💯 Very clear and concise.

davidhassell and others added 4 commits February 24, 2023 11:55
Co-authored-by: Sadie L. Bartholomew <[email protected]>
Co-authored-by: Sadie L. Bartholomew <[email protected]>
Co-authored-by: Sadie L. Bartholomew <[email protected]>
Co-authored-by: Sadie L. Bartholomew <[email protected]>
Copy link
Member

@sadielbartholomew sadielbartholomew left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

All minor feedback addressed, so good to go and merge (in case a re-confirmation is helpful).

@davidhassell davidhassell merged commit c831885 into NCAS-CMS:main Feb 27, 2023
@davidhassell davidhassell deleted the unique-constructs branch November 27, 2023 10:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

New ignore_properties keyword to cfdm.unique_constructs
2 participants