-
Notifications
You must be signed in to change notification settings - Fork 7
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
UFS-dev PR#65 #99
UFS-dev PR#65 #99
Conversation
* Update FV3 to a new version: Dycore semi-implicit solver update
…sing and combined with ufs-community#1730 WW3 update (ufs-community#1715) * update FV3 to better handle data source for regional model LBC processing * update WW3: PR#1730
* Update default_vars.sh to add noaacloud * Update detect_machine.sh to add noaacloud * Update module-setup.sh to add noaacloud env variables * Add noaacloud and env variable to rt.sh * Update module-setup.sh * Create ufs_noaacloud.intel.lua * Create ufs_common_spack.lua * Create compile_slurm.IN_noaacloud * Create fv3_slurm.IN_noaacloud * Update rt_utils.sh * Adding Requesting if statement to default_vars adding -B option back to nccmp
* This PR is created due to the ccpp-physics update for HR2 * PBL, Convection and Microphysics Update for HR2
Failed Hera/intel tests: |
Automated RT Failure Notification |
Automated RT Failure Notification |
@mkavulich I'm manually running Hera/intel right now (creating new baseline, and testing against them). |
@grantfirl I'm working on getting the automated tests up and running, sorry about that. We can discuss at today's meeting. |
@mkavulich This and associated PRs are ready to review. Once I get acceptance, I'll go ahead and start the merge sequence and start testing on the next one (#100) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Approving with a soap-box comment
@@ -43,7 +43,14 @@ elif [[ $MACHINE_ID = cheyenne* ]] ; then | |||
source /glade/u/apps/ch/modulefiles/default/localinit/localinit.sh | |||
fi | |||
module purge | |||
|
|||
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is hacky and terrible. Why are testing scripts trying to automatically determine what machine they are being run on instead of just being specified on the command line?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This comment should probably have gone under "detect_machine.sh", but it still stands
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think that this has been around for as long as I've been involved with the GFS. I suppose that it's handy for the end user -- one less thing to specify when running tests.
Identical to ufs-community#1731
Contains changes from: ufs-community#1720, ufs-community#1715, ufs-community#1667
1715 causes the following RTs to fail:
rrfs_smoke_conus13km_hrrr_warm
rrfs_smoke_conus13km_hrrr_warm_2threads
rrfs_conus13km_hrrr_warm
rrfs_smoke_conus13km_radar_tten_warm
rrfs_smoke_conus13km_hrrr_warm_debug
rrfs_smoke_conus13km_hrrr_warm_debug_2threads
rrfs_conus13km_hrrr_warm_debug
rrfs_conus13km_hrrr_warm_restart_mismatch
1720 causes all RTs to fail
Associated PRs:
NCAR/fv3atm#96
NCAR/ccpp-physics#1020