Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

UFS/dev PR#6 #70

Merged
merged 72 commits into from
Oct 27, 2022
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
72 commits
Select commit Hold shift + click to select a range
1bc290c
fixes for rrfs debug tests (uninitialized memory in fv_regional_bc an…
SamuelTrahanNOAA Sep 18, 2022
0970b5d
rrfs 13km debug tests
SamuelTrahanNOAA Sep 18, 2022
05a4275
smoke bug fixes for restart
SamuelTrahanNOAA Sep 19, 2022
e17f67f
RRFS tests, but smoke takes too long due to 2hr wallclock limit, need…
SamuelTrahanNOAA Sep 19, 2022
c73b94d
remove smoke test variants
SamuelTrahanNOAA Sep 20, 2022
b626819
remove workarounds and fix remaining known bugs in ps_reg
SamuelTrahanNOAA Sep 20, 2022
a7b1803
a few more surface pressure bug fixes; now the test case runs in debu…
SamuelTrahanNOAA Sep 20, 2022
7fcd28d
update conus13km test list
SamuelTrahanNOAA Sep 20, 2022
fc49cf6
merge develop into FV3
SamuelTrahanNOAA Sep 20, 2022
51f2a72
bug fixes to my bug fixes
SamuelTrahanNOAA Sep 20, 2022
418217f
update to top of dev/emc atmos_cubed_sphere
SamuelTrahanNOAA Sep 20, 2022
9964f4b
Merge remote-tracking branch 'origin/develop' into bugfix/rrfs-debug-…
SamuelTrahanNOAA Sep 20, 2022
6789ebd
update atmos_cubed_sphere to dev/emc
SamuelTrahanNOAA Sep 20, 2022
7a7774e
update atmos_cubed_sphere
SamuelTrahanNOAA Sep 20, 2022
e61592d
workarounds and bug fixes from gnu compiler testing
SamuelTrahanNOAA Sep 21, 2022
6b7cb3b
atmos_cubed_sphere fixes&tweaks; ccpp/physics fix for precision issue…
SamuelTrahanNOAA Sep 21, 2022
939948b
120s timestep for conus13km tests
SamuelTrahanNOAA Sep 21, 2022
6eaabeb
atmos_cubed_sphere: simplify comments and explain snan
SamuelTrahanNOAA Sep 21, 2022
4fb44cd
move task calculations to compute_petbounds_and_tasks in rt_utils.sh;…
SamuelTrahanNOAA Sep 22, 2022
ef3aa86
Merge remote-tracking branch 'sam/bugfix/rt-sh-tasks' into bugfix/rrf…
SamuelTrahanNOAA Sep 22, 2022
1199227
Merge remote-tracking branch 'sam/bugfix/rt-sh-tasks' into bugfix/rrf…
SamuelTrahanNOAA Sep 22, 2022
0476261
disable conus13km decomp and restart tests that are known to not matc…
SamuelTrahanNOAA Sep 22, 2022
9c41ded
Merge branch 'bugfix/rrfs-debug-mode' of ssh://github.com/SamuelTraha…
SamuelTrahanNOAA Sep 22, 2022
05149a7
hera.gnu tests pass, except conus13km decomp and restart which are ex…
SamuelTrahanNOAA Sep 22, 2022
7a354c4
Merge branch 'bugfix/rrfs-debug-mode' of ssh://github.com/SamuelTraha…
SamuelTrahanNOAA Sep 22, 2022
b6e7012
Point to Sam's branches of fv3atm, atmos cubed sphere, and ccpp physics
SamuelTrahanNOAA Sep 22, 2022
54a70e9
Merge branch 'bugfix/rrfs-debug-mode' of ssh://github.com/SamuelTraha…
SamuelTrahanNOAA Sep 22, 2022
096b2e9
merge upstream/develop change for ccpp/physics url
SamuelTrahanNOAA Sep 22, 2022
d7ec03a
hera.intel tests pass
SamuelTrahanNOAA Sep 22, 2022
ceb1d69
jet.intel tests passed
SamuelTrahanNOAA Sep 22, 2022
68e8e02
move sanity checks to lsm_ruc and add "snow on ice" check
SamuelTrahanNOAA Sep 26, 2022
11179b8
hera.gnu tests passed again.
SamuelTrahanNOAA Sep 26, 2022
5ae327d
use i-1 & j-1 for two-point averages, when available
SamuelTrahanNOAA Sep 27, 2022
fe0b042
hera.gnu tests pass against new baseline after atmos_cubed_sphere i-j…
SamuelTrahanNOAA Sep 27, 2022
b3bba20
jet intel tests passed
SamuelTrahanNOAA Sep 27, 2022
0385e29
Use saved routehandles in fv3 cap init phase (#1434)
DusanJovic-NOAA Oct 3, 2022
2186010
Replace many changes with atmos_cubed_sphere PR #220
SamuelTrahanNOAA Oct 3, 2022
5174c04
hera.gnu tests passed
SamuelTrahanNOAA Oct 3, 2022
14db6bb
Add RRFS-A to weekly tests (#1418)
RatkoVasic-NOAA Oct 4, 2022
e6da626
Check-in Jenkins Docker ORT CI (#1411)
Oct 4, 2022
ea0b6e4
Update CMake build system for AQM (#1445)
BrianCurtis-NOAA Oct 7, 2022
4dc1960
merge develop
SamuelTrahanNOAA Oct 10, 2022
807bfa8
hera gnu tests passed
SamuelTrahanNOAA Oct 10, 2022
5f8e1bf
jet intel tests passed
SamuelTrahanNOAA Oct 10, 2022
4972fb6
hera intel tests passed
SamuelTrahanNOAA Oct 11, 2022
2539086
NCAR/main PR #66 (Bugfix and optimization of prognostic closure for t…
Oct 11, 2022
369460b
intel hera tests passed again
SamuelTrahanNOAA Oct 11, 2022
22313cc
missing from prior commit: merge upstream to ccpp/physics; latest tes…
SamuelTrahanNOAA Oct 11, 2022
c0dc489
satisfy git's glitchiness
SamuelTrahanNOAA Oct 11, 2022
829b41f
hera gnu tests passed
SamuelTrahanNOAA Oct 11, 2022
b00ee13
merge upstream fv3
SamuelTrahanNOAA Oct 12, 2022
f04bcc2
merge upstream (except hera&jet test logs)
SamuelTrahanNOAA Oct 12, 2022
568f36e
update stochastic_physics url
SamuelTrahanNOAA Oct 12, 2022
1ae96af
add new BL_DATE
jkbk2004 Oct 12, 2022
94e257e
[AutoRT] hera.gnu Job Completed.
BrianCurtis-NOAA Oct 12, 2022
22ab217
[AutoRT] hera.intel Job Completed.
BrianCurtis-NOAA Oct 12, 2022
f9c6433
[AutoRT] orion.intel Job Completed.
BrianCurtis-NOAA Oct 13, 2022
fddfea1
[AutoRT] gaea.intel Job Completed.
BrianCurtis-NOAA Oct 13, 2022
292c65a
add jet.intel RT log: passed
jkbk2004 Oct 13, 2022
1349c2c
add cheyenne intel/gnu RT logs: passed
jkbk2004 Oct 13, 2022
e391921
WCOSS2 Intel RT Log
BrianCurtis-NOAA Oct 13, 2022
bb3da3c
point to EMC fv3atm
SamuelTrahanNOAA Oct 17, 2022
ed95f95
Merge branch 'bugfix/rrfs-debug-mode' into ufs-dev-PR6
Oct 18, 2022
94b6b86
update .gitmodules for testing
Oct 18, 2022
18891e9
update BL_DATE in rt.ncar.sh
Oct 19, 2022
e65365f
[AutoRT] hera.gnu Job Completed.
Oct 20, 2022
03be763
[AutoRT] hera.intel Job Completed.
Oct 20, 2022
afb4fbf
From jkbk2004:fix/cheyenne-lmod
Oct 25, 2022
80995ff
Merge pull request #2 from dustinswales/hotfix_cheyenneLMOD
grantfirl Oct 25, 2022
9617a19
[AutoRT] cheyenne.gnu Job Completed.
Oct 25, 2022
b16bd47
[AutoRT] cheyenne.intel Job Completed.
Oct 26, 2022
b997497
update FV3 submodule pointer and revert .gitmodules
Oct 27, 2022
File filter

Filter by extension

Filter by extension


Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
32 changes: 16 additions & 16 deletions .github/workflows/build_test.yml
Original file line number Diff line number Diff line change
Expand Up @@ -105,12 +105,12 @@ jobs:
sudo systemctl restart docker
sleep 10
cd tests/ci && ./ci.sh -n ${{ matrix.name }} -b ${{ matrix.case }}
sudo docker image ls

- name: Free up disk space
run: |
sudo docker rmi $(sudo docker image ls | grep -E -m1 '<none>' | awk '{ print $3 }')
sudo docker rmi $(sudo docker image ls | awk '/ubuntu-hpc/ { print $3 }')

#- name: Free up disk space
# run: |
# sudo docker images --no-trunc --all --quiet --filter="dangling=true" | sudo xargs --no-run-if-empty docker rmi

- uses: actions/upload-artifact@v2
with:
name: ${{ matrix.bld_set }}.artifact
Expand Down Expand Up @@ -174,14 +174,14 @@ jobs:
cd ${{ github.workspace }}/tests/ci
./ci.sh -n ${{ matrix.name }} -r ${{ matrix.case }}

- uses: actions/upload-artifact@v2
if: ${{ always() }}
with:
name: memory_stat_${{ matrix.test_set }}
path: memory_stat

- name: Clean up
if: ${{ always() }}
run: |
docker stop my-container && docker rm my-container
docker volume rm DataVolume
#- uses: actions/upload-artifact@v2
# if: ${{ always() }}
# with:
# name: memory_stat_${{ matrix.test_set }}
# path: memory_stat

#- name: Clean up
# if: ${{ always() }}
# run: |
#docker stop my-container && docker rm my-container
#docker volume rm DataVolume
2 changes: 1 addition & 1 deletion .gitmodules
Original file line number Diff line number Diff line change
Expand Up @@ -8,7 +8,7 @@
branch = dev/ufs-weather-model
[submodule "stochastic_physics"]
path = stochastic_physics
url = https://github.com/noaa-psd/stochastic_physics
url = https://github.com/NOAA-PSL/stochastic_physics
branch = master
[submodule "CMakeModules"]
path = CMakeModules
Expand Down
2 changes: 1 addition & 1 deletion AQM
Submodule AQM updated 1 files
+9 −7 CMakeLists.txt
2 changes: 1 addition & 1 deletion FV3
Submodule FV3 updated 3 files
+1 −1 atmos_cubed_sphere
+1 −1 ccpp/physics
+39 −15 fv3_cap.F90
588 changes: 316 additions & 272 deletions tests/RegressionTests_cheyenne.gnu.log

Large diffs are not rendered by default.

1,644 changes: 852 additions & 792 deletions tests/RegressionTests_cheyenne.intel.log

Large diffs are not rendered by default.

588 changes: 316 additions & 272 deletions tests/RegressionTests_hera.gnu.log

Large diffs are not rendered by default.

1,666 changes: 863 additions & 803 deletions tests/RegressionTests_hera.intel.log

Large diffs are not rendered by default.

15 changes: 8 additions & 7 deletions tests/ci/Dockerfile
Original file line number Diff line number Diff line change
@@ -1,19 +1,20 @@
From noaaemc/ubuntu-hpc:v1.11b
From noaaepic/ubuntu20.04-gnu9.3-hpc-stack:v1.2

CMD ["/bin/bash"]

ENV HOME=/home/builder
COPY --chown=builder:builder . $HOME/ufs-weather-model

USER builder
ENV USER=builder
ARG test_name
ARG build_case
ARG run_case
ENV test_name=$test_name
ENV build_case=$build_case
ENV test_case=
ENV run_case=$run_case
ENV CI_TEST=true
ENV RT_COMPILER=gnu
ENV RT_MACHINE=linux.gnu
ENV RT_MACHINE=linux
ENV MACHINE_ID=linux

WORKDIR $HOME/ufs-weather-model/tests
RUN ./opnReqTest -n $test_name -c $build_case -z && tar -cvzf fv3.tar.gz fv3_*.exe modules.fv3_*
CMD ./opnReqTest -n $test_name -c $test_case -x
CMD ./opnReqTest -n $test_name -c $run_case
75 changes: 75 additions & 0 deletions tests/ci/Jenkinsfile
Original file line number Diff line number Diff line change
@@ -0,0 +1,75 @@
pipeline {
agent none

options {
disableConcurrentBuilds()
overrideIndexTriggers(false)
skipDefaultCheckout(true)
}

stages {
stage('ORT') {
matrix {
axes {
axis {
name 'TEST_NAME'
values 'control', 'regional_control', 'cpld_control_nowave_noaero_p8'
}

axis {
name 'TEST_CASE'
values 'thr', 'mpi', 'dcp', 'rst', 'bit', 'dbg'
}
}

excludes {
exclude {
axis {
name 'TEST_NAME'
values 'regional_control'
}

axis {
name 'TEST_CASE'
values 'mpi', 'rst', 'bit', 'dbg'
}
}

exclude {
axis {
name 'TEST_NAME'
values 'cpld_control_nowave_noaero_p8'
}

axis {
name 'TEST_CASE'
values 'mpi', 'dcp', 'rst', 'bit', 'thr' // TODO: Remove thr case from cpld_control_nowave_noaero_p8 exclusions when it is passing again
}
}
}

stages {
stage('Test') {
when {
expression {
!changeRequest()
}
}

steps {
build job: 'ufs-weather-model/ort-docker-pipeline', parameters: [string(name: 'TEST_NAME', value: "${env.TEST_NAME}"), string(name: 'TEST_CASE', value: "${env.TEST_CASE}"), string(name: 'WRAPPER_GIT_BRANCH', value: "${env.BRANCH_NAME}")]
}
}

stage('Test for Change Request') {
when { changeRequest() }

steps {
build job: 'ufs-weather-model/ort-docker-pipeline', parameters: [string(name: 'TEST_NAME', value: "${env.TEST_NAME}"), string(name: 'TEST_CASE', value: "${env.TEST_CASE}"), booleanParam(name: 'WRAPPER_CHANGE_REQUEST', value: true), string(name: 'WRAPPER_GIT_BRANCH', value: "${env.CHANGE_TARGET}"), string(name: 'WRAPPER_CHANGE_BRANCH', value: "${env.CHANGE_BRANCH}"), string(name: 'WRAPPER_CHANGE_FORK', value: "${env.CHANGE_FORK}")]
}
}
}
}
}
}
}
4 changes: 2 additions & 2 deletions tests/compile.sh
Original file line number Diff line number Diff line change
Expand Up @@ -132,13 +132,13 @@ bash -x ${PATHTR}/build.sh

mv ${BUILD_DIR}/ufs_model ${PATHTR}/tests/${BUILD_NAME}.exe
if [[ "${MAKE_OPT}" == "-DDEBUG=ON" ]]; then
if [[ $MACHINE_ID == gaea.* ]]; then
if [[ $MACHINE_ID == gaea.* ]] || [[ $MACHINE_ID == linux.* ]]; then
cp ${PATHTR}/modulefiles/ufs_${MACHINE_ID}_debug ${PATHTR}/tests/modules.${BUILD_NAME}
else
cp ${PATHTR}/modulefiles/ufs_${MACHINE_ID}_debug.lua ${PATHTR}/tests/modules.${BUILD_NAME}.lua
fi
else
if [[ $MACHINE_ID == gaea.* ]]; then
if [[ $MACHINE_ID == gaea.* ]] || [[ $MACHINE_ID == linux.* ]]; then
cp ${PATHTR}/modulefiles/ufs_${MACHINE_ID} ${PATHTR}/tests/modules.${BUILD_NAME}
else
cp ${PATHTR}/modulefiles/ufs_${MACHINE_ID}.lua ${PATHTR}/tests/modules.${BUILD_NAME}.lua
Expand Down
1 change: 1 addition & 0 deletions tests/default_vars.sh
Original file line number Diff line number Diff line change
Expand Up @@ -370,6 +370,7 @@ export NSSL_INVERTCCN=.true.

# Smoke
export RRFS_SMOKE=.false.
export RRFS_RESTART=NO
export SEAS_OPT=2

# GWD
Expand Down
4 changes: 3 additions & 1 deletion tests/fv3_conf/fv3_qsub.IN_cheyenne
Original file line number Diff line number Diff line change
Expand Up @@ -13,7 +13,9 @@ echo -n " $( date +%s )," > job_timestamp.txt
set +x
MACHINE_ID=cheyenne
source ./module-setup.sh
module use $( pwd -P )
mkdir modulefiles
mv *.lua modulefiles
module use modulefiles
module load modules.fv3
module list
set -x
Expand Down
25 changes: 25 additions & 0 deletions tests/fv3_conf/regional_rrfs_a_run.IN
Original file line number Diff line number Diff line change
@@ -0,0 +1,25 @@
rsync -arv @[INPUTDATA_ROOT]/FV3_regional_input_data/. .

rm -rf INPUT RESTART
mkdir INPUT RESTART

rsync -arv @[INPUTDATA_ROOT]/fv3_regional_rrfs_a/INPUT/. INPUT/.

cp @[INPUTDATA_ROOT]/FV3_input_data_INCCN_aeroclim/MERRA2/merra2.aerclim.2003-2014.m01.nc aeroclim.m01.nc
cp @[INPUTDATA_ROOT]/FV3_input_data_INCCN_aeroclim/MERRA2/merra2.aerclim.2003-2014.m02.nc aeroclim.m02.nc
cp @[INPUTDATA_ROOT]/FV3_input_data_INCCN_aeroclim/MERRA2/merra2.aerclim.2003-2014.m03.nc aeroclim.m03.nc
cp @[INPUTDATA_ROOT]/FV3_input_data_INCCN_aeroclim/MERRA2/merra2.aerclim.2003-2014.m04.nc aeroclim.m04.nc
cp @[INPUTDATA_ROOT]/FV3_input_data_INCCN_aeroclim/MERRA2/merra2.aerclim.2003-2014.m05.nc aeroclim.m05.nc
cp @[INPUTDATA_ROOT]/FV3_input_data_INCCN_aeroclim/MERRA2/merra2.aerclim.2003-2014.m06.nc aeroclim.m06.nc
cp @[INPUTDATA_ROOT]/FV3_input_data_INCCN_aeroclim/MERRA2/merra2.aerclim.2003-2014.m07.nc aeroclim.m07.nc
cp @[INPUTDATA_ROOT]/FV3_input_data_INCCN_aeroclim/MERRA2/merra2.aerclim.2003-2014.m08.nc aeroclim.m08.nc
cp @[INPUTDATA_ROOT]/FV3_input_data_INCCN_aeroclim/MERRA2/merra2.aerclim.2003-2014.m09.nc aeroclim.m09.nc
cp @[INPUTDATA_ROOT]/FV3_input_data_INCCN_aeroclim/MERRA2/merra2.aerclim.2003-2014.m10.nc aeroclim.m10.nc
cp @[INPUTDATA_ROOT]/FV3_input_data_INCCN_aeroclim/MERRA2/merra2.aerclim.2003-2014.m11.nc aeroclim.m11.nc
cp @[INPUTDATA_ROOT]/FV3_input_data_INCCN_aeroclim/MERRA2/merra2.aerclim.2003-2014.m12.nc aeroclim.m12.nc

cp @[INPUTDATA_ROOT]/FV3_input_data_INCCN_aeroclim/aer_data/LUTS/optics_BC.v1_3.dat optics_BC.dat
cp @[INPUTDATA_ROOT]/FV3_input_data_INCCN_aeroclim/aer_data/LUTS/optics_DU.v15_3.dat optics_DU.dat
cp @[INPUTDATA_ROOT]/FV3_input_data_INCCN_aeroclim/aer_data/LUTS/optics_OC.v1_3.dat optics_OC.dat
cp @[INPUTDATA_ROOT]/FV3_input_data_INCCN_aeroclim/aer_data/LUTS/optics_SS.v3_3.dat optics_SS.dat
cp @[INPUTDATA_ROOT]/FV3_input_data_INCCN_aeroclim/aer_data/LUTS/optics_SU.v1_3.dat optics_SU.dat
26 changes: 25 additions & 1 deletion tests/fv3_conf/rrfs_warm_run.IN
Original file line number Diff line number Diff line change
Expand Up @@ -3,7 +3,31 @@ mkdir INPUT RESTART

OPNREQ_TEST=${OPNREQ_TEST:-false}
SUFFIX=${RT_SUFFIX}
cp -r @[INPUTDATA_ROOT]/FV3_input_data_conus13km/INPUT/* INPUT/

if [[ "${RRFS_RESTART:-NO}" == YES ]] ; then
# cp -r ../${DEP_RUN}${SUFFIX}/RESTART/${RESTART_FILE_PREFIX}.* ./INPUT
# rm -f INPUT/fv_core.res.*
# rm -f INPUT/fv_srf_wnd.res.*
# rm -f INPUT/fv_tracer.res.*
# rm -f INPUT/phy_data.*
# rm -f INPUT/sfc_data.*
cp @[INPUTDATA_ROOT]/FV3_input_data_conus13km/INPUT/grid_spec.nc INPUT/.
cp @[INPUTDATA_ROOT]/FV3_input_data_conus13km/INPUT/*_grid.tile*.nc INPUT/.
cp @[INPUTDATA_ROOT]/FV3_input_data_conus13km/INPUT/oro_data*.nc INPUT/.
for RFILE in ../${DEP_RUN}${SUFFIX}/RESTART/${RESTART_FILE_PREFIX}.*; do
[ -e $RFILE ] || exit 1
RFILE_OLD=$(basename $RFILE)
RFILE_NEW="${RFILE_OLD//${RESTART_FILE_PREFIX}./}"
cp $RFILE "INPUT/$RFILE_NEW"
done
for x in emi_data.nc SMOKE_GBBEPx_data.nc dust12m_data.nc gfs_ctrl.nc gfs_data.nc \
grid.tile7.halo4.nc ; do
cp @[INPUTDATA_ROOT]/FV3_input_data_conus13km/INPUT/$x INPUT/.
done
cp @[INPUTDATA_ROOT]/FV3_input_data_conus13km/INPUT/gfs_bndy.* INPUT/.
else
cp -r @[INPUTDATA_ROOT]/FV3_input_data_conus13km/INPUT/* INPUT/
fi

for x in global_glacier.2x2.grb global_h2oprdlos.f77 global_maxice.2x2.grb \
global_o3prdlos.f77 global_snoclim.1.875.grb global_zorclim.1x1.grb \
Expand Down
Loading