Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update NCAR dtc/develop from EMC master, apply missing updates from CCN/IN commit #40

Conversation

climbfuji
Copy link
Collaborator

@climbfuji climbfuji commented Apr 11, 2020

This PR contains:

Associated PRs:
NCAR/ccpp-physics#434
NCAR/fv3atm#42
#40

For regression testing, see #40.

climbfuji and others added 3 commits April 10, 2020 14:24
Add two options for IN/CCN activation and have total three options now:
* iccn=0 for temperature dependence, iccn=1 for climatological IN/CCN, and iccn=2 for MERRA2aersol
* add the option to enable RRTMg aerosol attenuation to be determined from prescribed MERRA2 climatology
* add aerosol optical depth outputs for total, dust, black carbon, organic carbon, sulfate, and sea salt

Add 4 regression tests:
 1) SAS+GFDL with enabled RRTMg aerosol attenuation from prescribed MERRA2 climatology (fv3_gocart_clm in rt.conf_csaw),
 2) CSAW+MG3 with with enabledRRTMg aerosol attenuation from prescribed MERRA2 climatology (fv3_gfsv16_csawmg  in rt.conf_csaw),
 3) CSAW+MG3 with enabled RRTMg aerosol attenuation from OPAC (fv3_gfsv16_csawmgt in rt.conf_csaw), and
 4) CSAW+MG3 with climatological IN/CCN with enabled RRTMg aerosol attenuation from prescribed MERRA2climatology (fv3_csawmg)
…r-model into update_dtc_develop_from_emc_develop_and_missing_ccnin_updates
@climbfuji climbfuji force-pushed the update_dtc_develop_from_emc_develop_and_missing_ccnin_updates branch from d12937e to 6c0f946 Compare April 13, 2020 20:34
@llpcarson
Copy link

Are you still running reg-tests for this one?

@climbfuji
Copy link
Collaborator Author

Are you still running reg-tests for this one?

Yes, I just wanted to give you a chance to look at this so that I can merge it relatively quickly. Will be adding information on regression testing below. Thanks for reviewing!

@llpcarson
Copy link

Are you still running reg-tests for this one?

Yes, I just wanted to give you a chance to look at this so that I can merge it relatively quickly. Will be adding information on regression testing below. Thanks for reviewing!

Thanks, the early look is very helpful, will approved once the RTs are done.

@climbfuji
Copy link
Collaborator Author

climbfuji commented Apr 13, 2020

Regression testing on hera.intel using rt.conf: slightly different approach than the last times.

  1. rsync the EMC baseline to the DTC location with the new date tag

  2. rsync the missing (= new from DTC) RRTMGP input data and regression test results from the old DTC date tag to the new date tag

  3. run the full regression tests; then, the following jobs fail:

fv3_ccpp_gfsv16_csawmg_prod
fv3_ccpp_gfsv16_csawmgt_prod
fv3_ccpp_gocart_clm_prod

The differences are in the phyf*.nemsio files only, pure diagnostics (text continues below):

bash-4.2$ /scratch2/NCEPDEV/fv3-cam/Dusan.Jovic/dnemsio/dnemsio -diff /scratch1/BMC/gmtb/ufs-weather-model/RT/NEMSfv3gfs/dtc-develop-20200413/INTEL/fv3_gocart_clm_ccpp/phyf000.nemsio /scratch1/BMC/gmtb/Dom.Heinzeller/FV3_RT/rt_281216/fv3_ccpp_gocart_clm_prod/phyf000.nemsio
 FAST_BYTESWAP ALGORITHM HAS BEEN USED AND DATA ALIGNMENT IS CORRECT FOR          4  )
  meta1
  -------------------------
 gtype        NEMSIO   OK
 gdatatype    bin4     OK
 modelname    FV3GFS   OK
 version      200809 OK
 nmeta          8 OK
 lmeta        120 OK
  meta2
  -------------------------
 nrec           151 OK
 idate         2016   10    3    0    0    0    1 OK
 dimx         384 OK
    1 dlwrf_ave        sfc                 1 OK
    2 dlwrf            sfc                 1 OK
    3 ulwrf_ave        sfc                 1 OK
    4 ulwrf            sfc                 1 OK
    5 dswrf_ave        sfc                 1 OK
    6 dswrf            sfc                 1 OK
    7 uswrf_ave        sfc                 1 OK
    8 uswrf            sfc                 1 OK
    9 duvb_ave         sfc                 1 OK
   10 cduvb_ave        sfc                 1 OK
   11 vbdsf_ave        sfc                 1 OK
   12 vddsf_ave        sfc                 1 OK
   13 nbdsf_ave        sfc                 1 OK
   14 nddsf_ave        sfc                 1 OK
   15 csulf            nom. top            1 OK
   16 csusf            nom. top            1 OK
   17 csdlf            sfc                 1 OK
   18 csusf            sfc                 1 OK
   19 csdsf            sfc                 1 OK
   20 csulf            sfc                 1 OK
   21 dswrf_ave        nom. top            1 OK
   22 uswrf_ave        nom. top            1 OK
   23 ulwrf_ave        nom. top            1 OK
   24 aod550           sfc                 1 min(diff)= 0.4275901E+02 max(diff)= 0.3551510E+04 rms1= 0.5116525E+03 rms2= 0.1421257E+00 digits=  -3 minloc=  68036 maxloc=  25085
   25 du_aod550        sfc                 1 min(diff)= 0.1986461E+01 max(diff)= 0.1761732E+04 rms1= 0.1637526E+03 rms2= 0.4548679E-01 digits=  -3 minloc=  35115 maxloc=  29585
   26 bc_aod550        sfc                 1 min(diff)= 0.4352293E+01 max(diff)= 0.2580979E+03 rms1= 0.3588449E+02 rms2= 0.9967915E-02 digits=  -3 minloc=  68424 maxloc=  24304
   27 oc_aod550        sfc                 1 min(diff)= 0.1017268E+02 max(diff)= 0.2330234E+04 rms1= 0.1665326E+03 rms2= 0.4625908E-01 digits=  -3 minloc=  30128 maxloc=  44582
   28 su_aod550        sfc                 1 min(diff)= 0.1498288E+02 max(diff)= 0.2707299E+04 rms1= 0.1981074E+03 rms2= 0.5502983E-01 digits=  -3 minloc=  65064 maxloc=  25085
   29 ss_aod550        sfc                 1 min(diff)= 0.5865656E+00 max(diff)= 0.4635436E+03 rms1= 0.1189960E+03 rms2= 0.3305444E-01 digits=  -3 minloc=  23915 maxloc=  39705
   30 tmin_min         2 m above gnd       1 OK
   31 tmax_max         2 m above gnd       1 OK
...

The reason for this are the changes in GFS_rrtmg_post.F90 in commit NCAR/ccpp-physics@7726128, which were made in IPD but forgotten in CCPP in the original PR NCAR/ccpp-physics#381

  1. Create a new baseline for these three tests only and merge into the new DTC date tag - successful

rt_hera_intel_newbaseline.log

  1. Rerun all tests using ./rt.sh -f -e 2>&1 | tee rt_hera_intel.log; this took two attempts, because in the first attempt several tests failed because of ongoing filesystem issues on hera. Rerunning those tests worked, in the end all tests passed.

rt_hera_intel.log
rt_hera_intel_fail_test.log
rt_hera_intel_rerun.log

@climbfuji
Copy link
Collaborator Author

Regression testing on cheyenne.gnu against new = old baseline (none of the tests in rt_gnu.conf are affected by these PRs): all tests pass.

rt_cheyenne_gnu.log

@climbfuji
Copy link
Collaborator Author

Regression testing on hera.intel using rt_ccpp_dtc.conf (because of the large number of changes in there): first, create temporary baseline, then verify against it. All tests pass.

rt_ccpp_dtc_create.log
rt_ccpp_dtc_verify.log

@climbfuji
Copy link
Collaborator Author

climbfuji commented Apr 14, 2020

Regression testing on cheyenne.intel:

First, create new baseline using rt_intel.conf: all tests complete successfully, baseline created.

rt_cheyenne_intel_create.log

Second, verify against this baseline: all tests pass.

rt_cheyenne_intel_verify.log

@climbfuji
Copy link
Collaborator Author

These PRs are ready to merge.

@climbfuji
Copy link
Collaborator Author

Based on Laurie's comment above I will merge this, since the tests all passed.

@climbfuji climbfuji merged commit 528c789 into NCAR:dtc/develop Apr 14, 2020
SamuelTrahanNOAA pushed a commit to SamuelTrahanNOAA/ufs-weather-model that referenced this pull request Sep 24, 2020
Enable subsurface cycling (fhcyc) for regression tests using RUC LSM and other GSL physics
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants