-
Notifications
You must be signed in to change notification settings - Fork 7
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update NCAR dtc/develop from EMC master, apply missing updates from CCN/IN commit #40
Update NCAR dtc/develop from EMC master, apply missing updates from CCN/IN commit #40
Conversation
Add two options for IN/CCN activation and have total three options now: * iccn=0 for temperature dependence, iccn=1 for climatological IN/CCN, and iccn=2 for MERRA2aersol * add the option to enable RRTMg aerosol attenuation to be determined from prescribed MERRA2 climatology * add aerosol optical depth outputs for total, dust, black carbon, organic carbon, sulfate, and sea salt Add 4 regression tests: 1) SAS+GFDL with enabled RRTMg aerosol attenuation from prescribed MERRA2 climatology (fv3_gocart_clm in rt.conf_csaw), 2) CSAW+MG3 with with enabledRRTMg aerosol attenuation from prescribed MERRA2 climatology (fv3_gfsv16_csawmg in rt.conf_csaw), 3) CSAW+MG3 with enabled RRTMg aerosol attenuation from OPAC (fv3_gfsv16_csawmgt in rt.conf_csaw), and 4) CSAW+MG3 with climatological IN/CCN with enabled RRTMg aerosol attenuation from prescribed MERRA2climatology (fv3_csawmg)
…r-model into update_dtc_develop_from_emc_develop_and_missing_ccnin_updates
d12937e
to
6c0f946
Compare
Are you still running reg-tests for this one? |
Yes, I just wanted to give you a chance to look at this so that I can merge it relatively quickly. Will be adding information on regression testing below. Thanks for reviewing! |
Thanks, the early look is very helpful, will approved once the RTs are done. |
Regression testing on hera.intel using rt.conf: slightly different approach than the last times.
The differences are in the phyf*.nemsio files only, pure diagnostics (text continues below):
The reason for this are the changes in GFS_rrtmg_post.F90 in commit NCAR/ccpp-physics@7726128, which were made in IPD but forgotten in CCPP in the original PR NCAR/ccpp-physics#381
rt_hera_intel.log |
Regression testing on cheyenne.gnu against new = old baseline (none of the tests in rt_gnu.conf are affected by these PRs): all tests pass. |
Regression testing on hera.intel using |
Regression testing on cheyenne.intel: First, create new baseline using Second, verify against this baseline: all tests pass. |
These PRs are ready to merge. |
Based on Laurie's comment above I will merge this, since the tests all passed. |
Enable subsurface cycling (fhcyc) for regression tests using RUC LSM and other GSL physics
This PR contains:
rt_ccpp_dtc.conf
that are covered inrt.conf
already, update the DTC regression test baseline date tag to 20200413Associated PRs:
NCAR/ccpp-physics#434
NCAR/fv3atm#42
#40
For regression testing, see #40.