Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add regression test fv3_ccpp_gsd_sar_25km_debug #19

Merged
merged 4 commits into from
Dec 26, 2019

Conversation

climbfuji
Copy link
Collaborator

This PR updates the submodule pointer for FV3 because of a bug fix for coldstarting models using RUC LSM with RAP/HRRR initial conditions (see NCAR/fv3atm#22). The PR also adds a new regression test fv3_ccpp_gsd_sar_25km_debug which would have detected the error.

@climbfuji climbfuji marked this pull request as ready for review December 23, 2019 23:19
@climbfuji
Copy link
Collaborator Author

@JeffBeck-NOAA @gsketefian for your information

@JeffBeck-NOAA
Copy link

JeffBeck-NOAA commented Dec 23, 2019 via email

@climbfuji
Copy link
Collaborator Author

Regression testing on hera/intel using rt.conf against DTC-maintained official baseline: all tests pass.

rt_full.log

@climbfuji
Copy link
Collaborator Author

Regression testing using NEMSCompsetRun on hera/intel against EMC baseline. All tests pass except fv3_gfdlmprad_noahmp. This is correct, because the dtc/develop branches contain a bugfix for Noah MP that is not yet included in EMC's code.

NEMSCompsetRun.log

@climbfuji
Copy link
Collaborator Author

Regression testing on hera/intel using rt_ccpp_gsd.conf (first create = CCPP static, then verify = CCPP static and CCPP dynamic). All tests pass, including the newly added fv3_ccpp_gsd_sar_25km_debug test.

rt_ccpp_gsd_create.log
rt_ccpp_gsd_verify.log

@climbfuji
Copy link
Collaborator Author

@llpcarson @grantfirl @ligiabernardet @tanyasmirnova @JeffBeck-NOAA this PR and NCAR/fv3atm#22 are ready to merge. They need to go into dtc/develop in the morning on Thu Dec 26 so that they will make it into the PR from dtc/develop to EMC's branches. Since the changes are straightforward and all tests passed, I will merge them w/o approval if necessary.

@climbfuji climbfuji merged commit 4c2d541 into NCAR:dtc/develop Dec 26, 2019
grantfirl added a commit that referenced this pull request Nov 30, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants