Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Dropping support for python 3.8 and adding 3.11 #426

Merged
merged 2 commits into from
Jun 21, 2023

Conversation

anissa111
Copy link
Member

@anissa111 anissa111 commented Jun 21, 2023

PR Summary

Closes #422

Fixes CI failures on main due to dropped support of 3.8 by dependencies and adds support for python 3.11

Summary of changes:

  • removes python 3.8 from supported versions
  • limits highest supported version to <=3.11

After this PR is merged:

  • I will go into the repo settings and add the 3.11 tests to the required list
  • Corresponding changes will need to be made in the feedstock repo at the time of the next release

PR Checklist

General

  • Make an issue if one doesn't already exist
  • Link the issue this PR resolves by adding closes #XXX to the PR description where XXX is the number of the issue.
  • Add a brief summary of changes to docs/release-notes.rst
  • Add appropriate labels to this PR
  • Make your changes in a forked repository rather than directly in this repo
  • Open this PR as a draft if it is not ready for review
  • Convert this PR from a draft to a full PR before requesting reviewers
  • Passes precommit. To set up on your local, run pre-commit install from the top level of the repository. To manually run pre-commits, use pre-commit run --all-files and re-add any changed files before committing again and pushing.

@anissa111 anissa111 added bug Something isn't working dependencies Pull requests that update a dependency file testing Issue related to testing labels Jun 21, 2023
@anissa111 anissa111 marked this pull request as ready for review June 21, 2023 21:06
@anissa111 anissa111 merged commit d1020e8 into NCAR:main Jun 21, 2023
@anissa111 anissa111 deleted the issue422 branch June 21, 2023 22:05
@anissa111
Copy link
Member Author

Okay, the required tests on branch protection should be updated!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working dependencies Pull requests that update a dependency file testing Issue related to testing
Projects
None yet
Development

Successfully merging this pull request may close these issues.

CI Failures: June 7
2 participants