Update of physics/cldwat2m_micro.F to match current version in NEMSfv… #85
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…3gfs/FV3/gfsphysics/physics/cldwat2m_micro.F
|
Given that this code is not exercised in the tests conducted, I am not sure how to make sure it is "correct". I would like to discuss before we merge. |
|
Hi, could someone approve please as discussed, so that I can move on with the other physics to update? Thank you! |
grantfirl
approved these changes
May 31, 2018
|
Thanks @grantfirl |
HelinWei-NOAA
referenced
this pull request
in HelinWei-NOAA/ccpp-physics
Jul 10, 2023
Fix bug in aerinterp read routines that break 32-bit physics and pass NetCDF errors up through errflg&errmsg
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR updates physics/cldwat2m_micro.F to match current version in NEMSfv3gfs/FV3/gfsphysics/physics/cldwat2m_micro.F.
Compilation was tested with SCM, FV3v0 (CCPP build) and NEMSfv3gfs on macosx.gnu and theia.intel. Since none of the routines in cldwart2m_micro.F is used in SCM or FV3v0 or the CCPP-version of NEMSfv3gfs, results are bit for bit identical.
This PR is the first one in a series to come that updates the physics source code in ccpp-physics/physics with changes between FV3v0 and FV3 current master.