Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bugfix for extra top layer GFS_rrtmg_pre setup #635

Merged
merged 2 commits into from
Apr 28, 2021

Conversation

matusmartini
Copy link
Collaborator

This pull request resolves #632

Includes fixes of array-out-of-bounds errors when extra top layer is used for pressure, temperature, and specific humidity for Thompson MP. Instead of prsl, tgrs, and qgrs extended arrays plyr, tlyr, and qlyr respectively are used which are defined in the extra top radiation layer.

Includes comment correction for pressure units for plyr, and removes white space.

matusmartini and others added 2 commits April 19, 2021 12:31
pulling latest master into local ltp-bugfix
…ure, temperature, and specific humidity for Thompson MP. Use extended arrays plyr, tlyr, and qlyr respectively.
Copy link
Collaborator

@climbfuji climbfuji left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks good to me, thanks very much for submitting this bugfix. I will look for a spot in the commit queue for your changes.

climbfuji added a commit that referenced this pull request Apr 28, 2021
Collect PRs #613, #628, #634, #635 / update long names and vertical dimension for atmosphere_heat_diffusivity and atmosphere_momentum_diffusivity
@climbfuji climbfuji merged commit f29be0c into NCAR:master Apr 28, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Bug in GFS_rrtmg_pre when extra top layer is used
2 participants