Move calculation of sncovr from FV3/io/FV3GFS_io.F90 to ccpp/physics/physics/GFS_phys_time_vary.XYZ.F90 #315
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This moves the calculation of the Sfcprop%sncovr variable from sfc_prop_restart_read subroutine in the FV3GFS_io.F90 file to GFS_phys_time_vary.XYZ.F90 in ccpp-physics. This was flagged as a problem by @climbfuji, and seemed to interfere with the NoahMP work (related to namelist_soilveg.F existing in both the CCPP and non-CCPP physics repos).
Work done:
(FV3)
(ccpp-physics)
NOTE: As far as I can tell, this code needs to go in GFS_phys_time_vary_run for the following reasons: