Chikira Sugiyama convection #167
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…the table in GFS_typedefs.F90
…cs_conv.F90 argument table to match those in GFS_typedefs.F90, units differ by delt - Add 'convective' to variable prec standard name - CCPP prebuild step completed successfully.
Fix dimensions of array q in cs_conv_pre_run Add interfaces to public list
…iver and GFS_typedefs: rain1, dt_mf, dd_mf, and ud_mf. Hopefully these will be resolved after the v2 release.
Use number_of_total_tracers_CS variable set in GFS_typedefs Update standard names in cs_conv_pre table
…intrinisic functions with explicit pure functions
|
Code updated to include the latest changes from trunk, regression tests kicked off. |
|
All regression tests passed, this and related PRs are good to go! rt_ccpp_hybrid.log |
|
Looks good to me. This CCPP-compliant cs_conv.F90 solves both GNU crashes and B4B identical issues on the original code in gfsphysics. |
|
@mzhangw no it doesn't solve the GNU crashes yet, unfortunately (this needs to be done at a later stage when we have more time - if that ever happens). |
grantfirl
reviewed
Oct 18, 2018
| !--------------------------------------------------------------------------------- | ||
| ! | ||
| use machine , only : r8 => kind_phys | ||
| use physcons, only : cp => con_cp, grav => con_g, & |
There was a problem hiding this comment.
We should address the constants coming from physcons in a cleanup PR.
grantfirl
approved these changes
Oct 18, 2018
|
This PR supersedes #164 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
From @mzhangw: Chikira-Sugiyama cumulus scheme (Chikira and Sugiyama 2010) with prognostic closure and Arakawa-Wu scale-aware extension is an offshoot of the prognostic Arakawa-Schubert scheme. It is characterized by lateral entrainment rates that vertically varies depending on buoyancy and vertical velocity of updraft air parcel following Gregory (2001) and spectral representation of cloud types according to updraft velocity at cloud base. Cloud base mass flux is determined by convective kinetic energy closure (Xu 1993; Pan and Randall 1998). The scheme naturally represents the effect of free-tropospheric humidity on deep convection through the vertical variation of the entrainment rates without any empirical triggering schemes.
These PRs contain GMTB’s efforts including implementation of the CCPP-compliant csconv.F90 in CCPP-physics, the suite definition file of CCPP csawmg RT test in CCPP-framework and other CCPP version configuration. It has provided bitwise identical reproducible results for csawmg RT test using Intel 18 in REPRO mode.
Work 99% done by @JulieSchramm and @mzhangw. Minor changes to achieve bit-for-bit identical results with CCPP and prevent some compile errors with gfortran (note that the code still crashes with the GNU compilers on all machines tested, Theia/Cheyenne/MacOSX, but fixing this is beyond the scope of this PR). From @JulieSchramm:
NCAR/ccpp-framework#150
#167
https://github.com/NCAR/FV3/pull/88
https://github.com/NCAR/NEMSfv3gfs/pull/62