Convert all schemes to new metadata, new unit conversion micrometer<->meter, merge gsd/develop #221
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… from micrometer to meter and vice versa
…ariables to GFS_typedefs-based dimensions dictionary that are not used by FV3
…if old metadata is found
| !! | local_name | standard_name | long_name | units | rank | type | kind | intent | optional | | ||
| !! |-----------------------------------|-------------------------- |-------------------------------------------------------|---------|------|-----------|----------|--------|----------| | ||
| !! | ccpp_t | ccpp_t | definition of type ccpp_t | DDT | 0 | ccpp_t | | none | F | | ||
| !! \htmlinclude ccpp_types.html |
There was a problem hiding this comment.
This change requires updates to the Technical Documentation (chapter 6) to reflect that ccpp_types.F90 no longer has a table. Let me know if you have time to do these changes or I can do them.
There was a problem hiding this comment.
Yes, please, make those changes if you can! Thanks, Dom
|
I am not clear on the process to create the SciDoc from all the .meta files. Does the user have to run metadata2html.py individually to convert each .meta file, or is there a more automated way to create all the .html files needed to include in the SciDoc? |
|
Not yet - but I want to automate this based on the ccpp_prebuild config. On my todo list for Monday.
… On Sep 5, 2019, at 10:59 AM, ligiabernardet ***@***.***> wrote:
I am not clear on the process to create the SciDoc from all the .meta files. Does the user have to run metadata2html.py individually to convert each .meta file, or is there a more automated way to create all the .html files needed to include in the SciDoc?
—
You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHub <#221?email_source=notifications&email_token=AB5C2RO6KXOASPEUIEAS6ZTQIE3HPA5CNFSM4ITUCX72YY3PNVWWK3TUL52HS4DFVREXG43VMVBW63LNMVXHJKTDN5WW2ZLOORPWSZGOD5727NA#issuecomment-528461748>, or mute the thread <https://github.com/notifications/unsubscribe-auth/AB5C2RJRBMMQC5XKBYTJWZTQIE3HPANCNFSM4ITUCX7Q>.
|
…ger needed since we can parse the separate .meta files directly
grantfirl
approved these changes
Sep 6, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
src/ccpp_types.F90to new metadata format (scripts/common.py: register missing CCPP internal variables)scripts/conversion_tools/unit_conversion.py: register unit conversion from micrometer to meter and vice versascripts/convert_metadata_schemes_using_typedef_dims.py: add missing variables to GFS_typedefs-based dimensions dictionary that are not used by FV3scripts/metadata_parser.py: warn or raise exception (currently warn) if old metadata is found