Adds bug fix in net_FW reported by travissluka #35
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
See following PR: NOAA-GFDL#664 Some of the code in ocn_comp_mct was copied from MOM_surface_forcing. Therefore this bug also affects dev/ncar. Since dev/ncar does not use MOM_surface_forcing, this fix should also be applied in ocn_comp_mct.
alperaltuntas
pushed a commit
that referenced
this pull request
Feb 5, 2021
Feature/update to gfdl 20200909 commit
alperaltuntas
pushed a commit
that referenced
this pull request
Aug 2, 2021
Merge in dev/gfdl updates
alperaltuntas
pushed a commit
that referenced
this pull request
Feb 18, 2022
* In MOM_ice_shelf_dynamics.F90 changes are made to calc_shelf_visc() and calc_shelf_driving_stress() to account for an irregular quadrilateral grid. In MOM_ice_shelf_initialize.F90 changes are made to initialize_ice_thickness_from_file() to correct masks at initialization. * Changed indentation * Changes are made to 'calc_shelf_visc()` to make computations of the velocity derivatives rotation-invariant. Changes in `update_ice_shelf()` utilize G%IareaT(:,:) instead of 1/G%areaT(:,:).
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
See following PR:
NOAA-GFDL#664
Some of the code in ocn_comp_mct was copied from MOM_surface_forcing. Therefore this bug also affects dev/ncar. Since dev/ncar does not use MOM_surface_forcing, this fix should also be applied in ocn_comp_mct.