(*) CFC_cap forcing update #236
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
add desc argument to log_param calls in MOM_CFC_cap
CFC_BC_FILE must be specified if USE_CFC_CAP=.true. use hemispheric averages poleward of 10 degrees latitude linearly interpolate between 10S and 10N correct bug that atm cfc12 was used in cfc11 flux computation
Codecov ReportPatch coverage has no change and project coverage change:
Additional details and impacted files@@ Coverage Diff @@
## dev/ncar #236 +/- ##
============================================
- Coverage 37.19% 37.19% -0.01%
============================================
Files 263 263
Lines 73147 73163 +16
Branches 13625 13625
============================================
+ Hits 27209 27210 +1
- Misses 40927 40942 +15
Partials 5011 5011
... and 1 file with indirect coverage changes Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. ☔ View full report in Codecov by Sentry. |
|
@klindsay28 Are these PRs ready for review? |
|
Yes, they are ready for review. |
alperaltuntas
approved these changes
Mar 16, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
read atm CFC hemispheric aveages from CFC_BC_FILE, instead of 2D fields
this changes CFC results
correct bug that atm cfc11 was used in cfc12 flux computation
this changes CFC12 results
add CFC_BC_year_offset, converts model time to time in CFC_BC_file
2 new parameters: CFC_BC_DATA_YEAR, CFC_BC_MODEL_YEAR
enables runs with CFC_cap to have model time different from CFC_BC_file time
PR must be paired with ESCOMP/MOM_interface#132
failures from aux_mom cheyenne_intel:
NLCOMP failures for all tests
changed CFC_BC_FILE value from MOM_interface PR
diag_table differs from baseline, but appears to be because of diff in casename in diag_table
BASELINE failure for DIMCS_Ld1.TL319_t061.GMOM_JRA.cheyenne_intel.mom-cfc_mods--mom-debug
expected answer change