Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Ensures that only one context menu is open at a time #1636

Merged
merged 2 commits into from
Feb 26, 2025
Merged

Ensures that only one context menu is open at a time #1636

merged 2 commits into from
Feb 26, 2025

Conversation

duranb
Copy link
Collaborator

@duranb duranb commented Feb 25, 2025

This fixes an issue where right clicking on multiple components with the custom context menu component results in multiple context menus can appear.

To test:

  1. Open a plan
  2. Switch two panels to be the activity directives table.
  3. Right click on one panel's table
  4. Right click on the other panel's table
  5. Verify that only the last context menu to be opened is visible.

@duranb duranb requested a review from a team as a code owner February 25, 2025 20:58
@ivydeliz
Copy link
Contributor

Tested as well and works as advertised :shipit:

@sonarqubecloud SonarQubeCloud
Copy link

Quality Gate Passed Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
0.0% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarQube Cloud

@duranb duranb merged commit 0d1b419 into develop Feb 26, 2025
6 checks passed
@duranb duranb deleted the fix/single-context-menu branch February 26, 2025 19:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@AaronPlave AaronPlave AaronPlave approved these changes

@dandelany dandelany Awaiting requested review from dandelany dandelany is a code owner automatically assigned from NASA-AMMOS/aerie-frontend

@joswig joswig Awaiting requested review from joswig joswig is a code owner automatically assigned from NASA-AMMOS/aerie-frontend

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@duranb @ivydeliz @AaronPlave