Copy & Paste of Activity Directives between Plans #1627

ivydeliz · 2025-02-10T21:16:19Z

Extending the original Copy & Paste feature with a few things here...

Let's use the system Clipboard, instead of session storage. This will allow us to deconflict having a separate special clipboard for Aerie, and it enables more features like...
Copy & Paste between plans. Open two plans, you can copy from plan A and paste on plan B either on the table or on the timeline at a specific time.
Now that we handle different plans, they can have different boundaries, so if you're pasting and the earliest start is out of bounds, then we're going to paste at the start of the plan.

src/components/activity/ActivityDirectivesTable.svelte

duranb · 2025-02-11T20:30:47Z

src/components/activity/ActivityDirectivesTable.svelte

-      <ContextMenuItem on:click={pasteActivityDirectives}>{getPasteActivityDirectivesText()}</ContextMenuItem>
-      <ContextMenuSeparator></ContextMenuSeparator>
-    {/if}
+    {#await canPasteActivityDirectives() then howMany}


Can we keep this option always visible, but disabled if they don't have anything to paste in?

Would it be possible to do this without the await wrapping the menu item?

@duranb it doesn't hide the single Paste menu item, but i found that it would await until that is done to show the context menu altogether. I can spend time figuring this out, but if we paste 100,000 activities i think the context menu lag might be a small problem compared to handling that kind of operation.

I'll see if I can test it out

@duranb ok i tested, when you have around 20k activities in the clipboard context menu starts to lag. i started looking into caching this info, but the point of this feature is to work between plans so even if i cache the info on one instance, the other instance will be wrong. Let's tag up Monday.

Sounds good! I think I'm less worried about it taking a while to load and more that the user isn't presented with all the options. Can we maybe kick off the serialization when it opens and show a loading message where the option to paste would normally go?

Or are you saying that the process of serialization is the part that's lagging the UI?

src/utilities/clipboard.ts

ivydeliz · 2025-02-13T18:01:18Z

@duranb addressed feedback! and actually simplified it! Give it a look when you can.

src/utilities/activities.ts

src/components/activity/ActivityDirectivesTable.svelte

duranb · 2025-02-19T19:43:24Z

src/components/timeline/TimelineContextMenu.svelte

@@ -432,18 +428,35 @@
      >
        Set Simulation End
      </ContextMenuItem>
-      {#if canPasteActivityDirectives()}
+      {#await getActivityDirectivesClipboardCount() then directivesInClipboard}


Is there still a chance that this menu item won't show while it's loading the count? Is it always quick to pop in?

I'm sure there's still a chance if you're trying to copy/paste tens of thousands of activities

Yeah that makes sense. Can we instead save the count to a variable and instead of awaiting to show the menu option, just show the option with a 0 count and disabling it to be consistent with always showing options?

@duranb since we're using the system clipboard we first need to make sure the clipboard has activity directives and then we get how many there are. So keeping the count doesn't really help me because we still have to deserialize the clipboard to see if it's the right type of content.

But my concern here is that we're hiding menu items from the user while waiting for the clipboard to deserialize. It's probably not likely that it would take long to deserialize, but I just want to make sure that the UX is consistent.

see my comment above, sorry we're having this chat in two different places where the same thing is happening 😄

src/utilities/clipboard.ts

duranb · 2025-02-26T19:32:44Z

src/components/activity/ActivityDirectivesTable.svelte

@@ -67,6 +68,12 @@
    errorCounts: activityDirectiveErrorRollupsMap?.[activityDirective.id]?.errorCounts,
  }));

+  $: permissionErrorText = planReadOnly


Do you mind changing this to not have a nested ternary? It can be a little difficult to immediately grok.

@duranb pushed a change to handle this

duranb · 2025-02-26T19:36:13Z

src/components/timeline/TimelineContextMenu.svelte

@@ -432,18 +428,35 @@
      >
        Set Simulation End
      </ContextMenuItem>
-      {#if canPasteActivityDirectives()}
+      {#await getActivityDirectivesClipboardCount() then directivesInClipboard}


But my concern here is that we're hiding menu items from the user while waiting for the clipboard to deserialize. It's probably not likely that it would take long to deserialize, but I just want to make sure that the UX is consistent.

sonarqubecloud · 2025-02-28T16:35:43Z

Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
0.0% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarQube Cloud

ivydeliz temporarily deployed to test-workflow February 10, 2025 21:16 — with GitHub Actions Inactive

ivydeliz temporarily deployed to test-workflow February 10, 2025 21:21 — with GitHub Actions Inactive

ivydeliz force-pushed the feature/copy-paste-directives-between-plans branch from fab1cfa to e5c2ec1 Compare February 10, 2025 21:28

ivydeliz had a problem deploying to test-workflow February 10, 2025 21:28 — with GitHub Actions Failure

ivydeliz self-assigned this Feb 10, 2025

ivydeliz had a problem deploying to test-workflow February 10, 2025 21:42 — with GitHub Actions Failure

ivydeliz marked this pull request as ready for review February 10, 2025 21:53

ivydeliz requested a review from a team as a code owner February 10, 2025 21:53

ivydeliz requested review from dandelany, AaronPlave and joswig February 10, 2025 21:53

ivydeliz changed the title ~~Copy & Paste of Activity Directives between Plans (#1625)~~ Copy & Paste of Activity Directives between Plans Feb 10, 2025

ivydeliz had a problem deploying to test-workflow February 10, 2025 21:54 — with GitHub Actions Failure

duranb requested changes Feb 11, 2025

View reviewed changes

ivydeliz temporarily deployed to test-workflow February 11, 2025 21:38 — with GitHub Actions Inactive

ivydeliz force-pushed the feature/copy-paste-directives-between-plans branch from e5c2ec1 to 258e0ba Compare February 13, 2025 17:40

ivydeliz temporarily deployed to test-workflow February 13, 2025 17:40 — with GitHub Actions Inactive

ivydeliz force-pushed the feature/copy-paste-directives-between-plans branch from 258e0ba to 3796dac Compare February 13, 2025 17:50

ivydeliz temporarily deployed to test-workflow February 13, 2025 17:50 — with GitHub Actions Inactive

ivydeliz requested a review from duranb February 13, 2025 18:00

AaronPlave reviewed Feb 14, 2025

View reviewed changes

src/utilities/activities.ts Outdated Show resolved Hide resolved

AaronPlave reviewed Feb 14, 2025

View reviewed changes

src/utilities/activities.ts Outdated Show resolved Hide resolved

duranb requested changes Feb 19, 2025

View reviewed changes

ivydeliz force-pushed the feature/copy-paste-directives-between-plans branch from 3796dac to 0f7ae85 Compare February 20, 2025 04:19

ivydeliz temporarily deployed to test-workflow February 20, 2025 04:19 — with GitHub Actions Inactive

ivydeliz force-pushed the feature/copy-paste-directives-between-plans branch from 0f7ae85 to 848dfbe Compare February 25, 2025 03:21

ivydeliz temporarily deployed to test-workflow February 25, 2025 03:21 — with GitHub Actions Inactive

ivydeliz requested a review from duranb February 25, 2025 03:23

dandelany temporarily deployed to test-workflow February 25, 2025 19:21 — with GitHub Actions Inactive

duranb requested changes Feb 26, 2025

View reviewed changes

Copy & Paste of Activity Directives between Plans (#1625)

1207af9

ivydeliz force-pushed the feature/copy-paste-directives-between-plans branch from 848dfbe to 1207af9 Compare February 28, 2025 16:35

ivydeliz deployed to test-workflow February 28, 2025 16:35 — with GitHub Actions Active

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Copy & Paste of Activity Directives between Plans #1627

Copy & Paste of Activity Directives between Plans #1627

ivydeliz commented Feb 10, 2025 •

edited by dandelany

Loading

duranb Feb 11, 2025

duranb Feb 26, 2025

ivydeliz Feb 28, 2025

ivydeliz Feb 28, 2025

ivydeliz Feb 28, 2025

duranb Feb 28, 2025

duranb Feb 28, 2025

ivydeliz commented Feb 13, 2025 •

edited

Loading

duranb Feb 19, 2025

ivydeliz Feb 20, 2025

duranb Feb 20, 2025

ivydeliz Feb 25, 2025 •

edited

Loading

duranb Feb 26, 2025

ivydeliz Feb 28, 2025

duranb Feb 26, 2025

ivydeliz Feb 28, 2025

duranb Feb 26, 2025

sonarqubecloud bot commented Feb 28, 2025

Copy & Paste of Activity Directives between Plans #1627

Are you sure you want to change the base?

Copy & Paste of Activity Directives between Plans #1627

Conversation

ivydeliz commented Feb 10, 2025 • edited by dandelany Loading

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

ivydeliz commented Feb 13, 2025 • edited Loading

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

ivydeliz Feb 25, 2025 • edited Loading

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

sonarqubecloud bot commented Feb 28, 2025

Quality Gate passed

ivydeliz commented Feb 10, 2025 •

edited by dandelany

Loading

ivydeliz commented Feb 13, 2025 •

edited

Loading

ivydeliz Feb 25, 2025 •

edited

Loading