Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Vml Library Support #1602

Merged
merged 47 commits into from
Feb 11, 2025
Merged

Vml Library Support #1602

merged 47 commits into from
Feb 11, 2025

Conversation

joswig
Copy link
Collaborator

@joswig joswig commented Jan 23, 2025 •
edited
Loading

resolves #1610

  • Library Sequences
    • Adds other sequences in workspace into scope
    • Linter checks spawn statements against in scope library sequences
    • Wired up form view to view/edit parameter values to spawned sequences
  • Global and Local variables
    • Provided to content assist for completion
    • Linter checks that variable names are defined. No type checking of variables in this PR.
  • VML Grammar
    • Changed rules for encoded strings to match sample data
    • Removed Function_name from ISSUE_DYNAMIC
    • Specified external functions require single set of parenthesis
    • Allow date ranges as Call_parameter
  • Miscellaneous
    • Bug fix - removes duplicate display of command description
    • Adds button to display diagnostic panel

Juno test files available on JPL net.

@joswig joswig force-pushed the feat/vml_libraries branch from 04fbbe2 to 1acdc23 Compare February 2, 2025 04:05
@joswig joswig force-pushed the feat/vml_libraries branch from 6bded13 to 553ee27 Compare February 3, 2025 17:31
@joswig joswig force-pushed the feat/vml_libraries branch from 0f3fcfe to 2be0db9 Compare February 3, 2025 23:52
@joswig joswig force-pushed the feat/vml_libraries branch from 9bcdafe to bad0bbc Compare February 4, 2025 21:56
joswig added 21 commits February 11, 2025 15:20
@joswig
expand docs on issue vs issue_dynamic
03b1cae
@joswig
split up numerci cases
8aabb7e
@joswig
readability of content assist
7b6c973
@joswig
stricter types
d71c560
@joswig
readability of completion code
e11e454
@joswig
add comment to make SeqN adaptation symmetric
a46b0f2
@joswig
reduce conditional nesting
f1f6086
@joswig
fix svelte-check lint
b102f8b
@joswig
remove extraneous truthyness check
74a73f9
@joswig
reduce nesting
ef5fe65
@joswig
reduce nesting
f9348ab
@joswig
Define constant for language name
72e2a05
@joswig
remove try/catch around svelte component creation
578c28b
@joswig
enum for sequence types
6543a6f
@joswig
wrap form inputs in div for byte editor
e7929d3
@joswig
helper for computing library sequences for seqn
919dca4
@joswig
missed file in prior commit
ebf874e
@joswig
smaller pieces for auto-complete
451932c
@joswig
better handling of typing new issue, issue_dynamic, etc
cfea843
@joswig
minor cleanup
69a9cb0
@joswig
Move SequenceTypes to enums file
2331c08
@joswig joswig force-pushed the feat/vml_libraries branch from 3c263a6 to 2331c08 Compare February 11, 2025 23:20
@sonarqubecloud SonarQubeCloud
Copy link

sonarqubecloud bot commented Feb 11, 2025 •
edited
Loading

Quality Gate Passed Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
No data about Coverage
0.0% Duplication on New Code

See analysis details on SonarQube Cloud

@joswig joswig merged commit 7c597e9 into develop Feb 11, 2025
6 checks passed
@joswig joswig deleted the feat/vml_libraries branch February 11, 2025 23:43
@dandelany dandelany mentioned this pull request Feb 12, 2025
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@duranb duranb duranb approved these changes

@goetzrrGit goetzrrGit goetzrrGit approved these changes

@dandelany dandelany Awaiting requested review from dandelany dandelany is a code owner automatically assigned from NASA-AMMOS/aerie-frontend

@AaronPlave AaronPlave Awaiting requested review from AaronPlave AaronPlave is a code owner automatically assigned from NASA-AMMOS/aerie-frontend

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Check VML block library parameters
3 participants
@joswig @duranb @goetzrrGit