Feature/svelte stellar tailwind #1532
Draft
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
AaronPlave
had a problem deploying
to
test-workflow
GitHub Actions
Failure
AaronPlave
had a problem deploying
to
test-workflow
GitHub Actions
Failure
AaronPlave
force-pushed
the
feature/svelte-stellar-tailwind
branch
from
48842e8 to
8792c1e
Compare
AaronPlave
had a problem deploying
to
test-workflow
GitHub Actions
Failure
AaronPlave
had a problem deploying
to
test-workflow
GitHub Actions
Failure
AaronPlave
had a problem deploying
to
test-workflow
GitHub Actions
Failure
AaronPlave
commented
Mar 5, 2025
src/components/menus/AppMenu.svelte
Outdated
There was a problem hiding this comment.
Should be able to remove this old AppMenu
AaronPlave
commented
Mar 5, 2025
src/routes/tags/+page.svelte
Outdated
| </div> | ||
| </fieldset> | ||
|
|
||
| <fieldset> | ||
| <div class="tags-creator st-typography-body"> | ||
| <!-- TODO: remove this fieldset --> |
AaronPlave
commented
Mar 5, 2025
| {/if} | ||
| </svelte:fragment> | ||
| </Panel> | ||
| </CssGrid> | ||
| </CssGrid> | ||
|
|
||
| <style> | ||
| <!-- TODO: remove this --> |
AaronPlave
force-pushed
the
feature/svelte-stellar-tailwind
branch
from
c619be3 to
7686e14
Compare
AaronPlave
had a problem deploying
to
test-workflow
GitHub Actions
Failure
AaronPlave
commented
Mar 6, 2025
| <TagChip | ||
| tag={{ color: $colorField.value, id: -1, name: $nameField.value || 'Tag Name' }} | ||
| removable={false} | ||
| /> | ||
| <span class="flex items-center border border-secondary pl-2 align-middle">@{user?.id}</span> |
There was a problem hiding this comment.
What is the purpose of the @user?
AaronPlave
had a problem deploying
to
test-workflow
GitHub Actions
Failure
AaronPlave
had a problem deploying
to
test-workflow
GitHub Actions
Failure
AaronPlave
had a problem deploying
to
test-workflow
GitHub Actions
Failure
AaronPlave
had a problem deploying
to
test-workflow
GitHub Actions
Failure
AaronPlave
had a problem deploying
to
test-workflow
GitHub Actions
Failure
AaronPlave
had a problem deploying
to
test-workflow
GitHub Actions
Failure
|
AaronPlave
had a problem deploying
to
test-workflow
GitHub Actions
Failure
AaronPlave
had a problem deploying
to
test-workflow
GitHub Actions
Failure
AaronPlave
had a problem deploying
to
test-workflow
GitHub Actions
Failure
AaronPlave
had a problem deploying
to
test-workflow
GitHub Actions
Failure
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR integrates TailwindCSS and Stellar Svelte components. TailwindCSS is a CSS utility framework introduced as a soft dependency of Stellar Svelte. Over time the aim is to use TailwindCSS utility classes instead of our custom classes so that all of our styling is responsive to the underlying CSS variables that govern those utility classes from Tailwind. Stellar Svelte is built on top of shadcn-svelte components which uses Tailwind itself for styling and dynamic theming. By using Tailwind in Aerie UI we will be able to dynamically theme (light, dark, global color schemes, etc). Stellar Svelte components will provide us with a large library of high quality, accessible UI components that should also save us development effort.
This PR also:
Testing:
TODO: