Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add feature for defining model specifications #1221

Merged
merged 27 commits into from
May 3, 2024

Conversation

duranb
Copy link
Collaborator

@duranb duranb commented Apr 10, 2024

resolves #1212

To test:

  1. Create constraint(s)
  2. Create scheduling condition(s)
  3. Create scheduling goal(s)
  4. Create a model
  5. Click on the newly created model in the models table
  6. Click on the new "Edit details and associations" button on the left, under the model's metadata
  7. Verify that you are taken to the new edit model page
  8. Modify the model metadata (i.e. name, description, etc)
  9. Click on the "Constraints" tab
  10. Click the "Library" tab
  11. Toggle on the checkboxes for all the constraints that you want to add
  12. Click the "Model" tab
  13. Verify that all the constraints that you toggled on are present
  14. Choose specific versions of the constraints that you prefer
  15. Click on the "Conditions" tab and repeat steps 10 - 14, but for scheduling conditions
  16. Click on the "Goals" tab and repeat steps 10 - 14, but for scheduling goals
  17. For goals, also update the priority if desired
  18. Click the "Save" button at the top right
  19. Verify that all changes are persisted after a refresh

@duranb duranb added the feature New feature or request label Apr 10, 2024
@duranb duranb self-assigned this Apr 10, 2024
@duranb duranb temporarily deployed to test-workflow April 11, 2024 00:46 — with GitHub Actions Inactive
@duranb duranb force-pushed the feature/1212-model-specifications branch from 4d7347f to 804cfc3 Compare April 12, 2024 00:40
@duranb duranb marked this pull request as ready for review April 12, 2024 00:51
@duranb duranb requested a review from a team as a code owner April 12, 2024 00:51
@duranb duranb temporarily deployed to test-workflow April 12, 2024 00:55 — with GitHub Actions Inactive
@duranb duranb temporarily deployed to test-workflow April 12, 2024 03:04 — with GitHub Actions Inactive
@duranb duranb temporarily deployed to test-workflow April 12, 2024 03:32 — with GitHub Actions Inactive
@duranb duranb force-pushed the feature/1212-model-specifications branch from 839eb78 to c9ed061 Compare April 12, 2024 16:06
@duranb duranb temporarily deployed to test-workflow April 12, 2024 16:06 — with GitHub Actions Inactive
@duranb duranb temporarily deployed to test-workflow April 12, 2024 16:24 — with GitHub Actions Inactive
@duranb duranb temporarily deployed to test-workflow April 12, 2024 16:39 — with GitHub Actions Inactive
@duranb duranb temporarily deployed to test-workflow April 12, 2024 20:40 — with GitHub Actions Inactive
@duranb duranb force-pushed the feature/1212-model-specifications branch from 2144297 to 429dab6 Compare April 17, 2024 18:47
@duranb duranb temporarily deployed to test-workflow April 17, 2024 18:48 — with GitHub Actions Inactive
@duranb duranb temporarily deployed to test-workflow April 17, 2024 18:56 — with GitHub Actions Inactive
@duranb duranb temporarily deployed to test-workflow April 17, 2024 19:38 — with GitHub Actions Inactive
@duranb duranb force-pushed the feature/1212-model-specifications branch from 02c62c0 to b33b6e4 Compare April 18, 2024 18:33
@duranb duranb temporarily deployed to test-workflow April 18, 2024 18:33 — with GitHub Actions Inactive
@duranb duranb force-pushed the feature/1212-model-specifications branch from 8b54d46 to 8cb1ed8 Compare May 2, 2024 18:12
@duranb duranb temporarily deployed to test-workflow May 2, 2024 18:12 — with GitHub Actions Inactive
@duranb duranb temporarily deployed to test-workflow May 3, 2024 01:27 — with GitHub Actions Inactive
@duranb duranb merged commit 9a88041 into develop May 3, 2024
5 checks passed
@duranb duranb deleted the feature/1212-model-specifications branch May 3, 2024 02:30
JosephVolosin pushed a commit that referenced this pull request Aug 20, 2024
* use more explicit variables for specifications
* add "danger" button styling
* navigate to edit model after creation
* subscribe to model changes
* reset plan creation stores upon navigating away to clear plan creation error message
JosephVolosin pushed a commit that referenced this pull request Oct 21, 2024
* use more explicit variables for specifications
* add "danger" button styling
* navigate to edit model after creation
* subscribe to model changes
* reset plan creation stores upon navigating away to clear plan creation error message
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
feature New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Model Specification Implementation
3 participants