-
Notifications
You must be signed in to change notification settings - Fork 26
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Issue #83 - Baseline example configs across repos #114
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Few minor things to get dropped. Branch needs rebased to get rid of the gitignore
commits since they're merged in another PR.
Removed extra data directory layer so data/config -> config/
Adding files present in ait-dsn/config but missing from ait-core/config
Removed limits directory layer within config directory
Add build/lib/* to .gitignore
Added missing dsn configs to core config.yaml and tlm.yaml
Removing references to removed data/ directory layer.
Removing references to removed config/limits/ directory layer.
Modifying relative path to work with new dir structure. Should be changed to derive path from ait.config in future (see Issue NASA-AMMOS#115)
Removing unnecessary files.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks great. We can drop config/data_field_defn.yaml
from this PR as well. I didn't notice it when I looked at it before. Sorry!!!
Removing more unnecessary files.
Issue #113 - Relocation aos_deframer example and add header
Changes are as follows:
config.yaml
andtlm.yaml
ait-dsn/config
but missing fromait-core/config
data/config
->config/
data/
directory layer.config/limits/
->config
limits/
directory layer.I also added
build/lib/*
and*.DS_Store
to .gitignoreResolves #83