Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Issue #83 - Baseline example configs across repos #114

Merged
merged 10 commits into from
Sep 21, 2018

Conversation

aywaldron
Copy link
Contributor

@aywaldron aywaldron commented Sep 5, 2018

Changes are as follows:

  • Added missing dsn configs to core config.yaml and tlm.yaml
  • Adding files present in ait-dsn/config but missing fromait-core/config
  • Removed extra data directory layer so data/config -> config/
  • Removing references to removed data/ directory layer.
  • Removed limits directory layer within config directory so config/limits/ -> config
  • Removing references to removed limits/ directory layer.

I also added build/lib/* and *.DS_Store to .gitignore

Resolves #83

@aywaldron aywaldron requested review from a team as code owners September 5, 2018 22:15
@MJJoyce MJJoyce changed the title Issue 83 - Baseline example configs across repos Issue #83 - Baseline example configs across repos Sep 6, 2018
Copy link
Member

@MJJoyce MJJoyce left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Few minor things to get dropped. Branch needs rebased to get rid of the gitignore commits since they're merged in another PR.

Removed extra data directory layer so data/config -> config/
Adding files present in ait-dsn/config but missing from
ait-core/config
Removed limits directory layer within config directory
Add build/lib/* to .gitignore
Added missing dsn configs to core config.yaml and tlm.yaml
Removing references to removed data/ directory layer.
Removing references to removed config/limits/ directory layer.
Modifying relative path to work with new dir structure.
Should be changed to derive path from ait.config in future
(see Issue NASA-AMMOS#115)
Copy link
Member

@MJJoyce MJJoyce left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great. We can drop config/data_field_defn.yaml from this PR as well. I didn't notice it when I looked at it before. Sorry!!!

@MJJoyce MJJoyce merged commit 590334b into NASA-AMMOS:master Sep 21, 2018
@aywaldron aywaldron deleted the issue-83 branch September 21, 2018 15:50
Mejiro-McQueen referenced this pull request in Mejiro-McQueen/Bifrost Feb 9, 2023
Issue #113 - Relocation aos_deframer example and add header
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants