Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

TIME40 dtype doesn't take up the proper number of bytes #81

Closed
MJJoyce opened this issue May 29, 2018 · 0 comments
Closed

TIME40 dtype doesn't take up the proper number of bytes #81

MJJoyce opened this issue May 29, 2018 · 0 comments
Assignees

Comments

@MJJoyce
Copy link
Member

MJJoyce commented May 29, 2018

The TIME40 type definition is based around a MSB_U32 primitive type. As such, the size of TIME40 is set as 4 bytes / 32 bits instead of proper size of 5 bytes / 40 bits.

@MJJoyce MJJoyce self-assigned this May 29, 2018
MJJoyce added a commit that referenced this issue Jun 6, 2018
Update Time40 byte/bit counts to properly reflect the dtype's size.
Because it's based off a MSB_U32 primitive type. This was causing issues
with the expected length of packets that used Time40 given the 4 byte
length of a MSB_U32.
MJJoyce added a commit that referenced this issue Jun 19, 2018
Update Time40 byte/bit counts to properly reflect the dtype's size.
Because it's based off a MSB_U32 primitive type. This was causing issues
with the expected length of packets that used Time40 given the 4 byte
length of a MSB_U32.
MJJoyce added a commit that referenced this issue Sep 4, 2019
Update Time40 byte/bit counts to properly reflect the dtype's size.
Because it's based off a MSB_U32 primitive type. This was causing issues
with the expected length of packets that used Time40 given the 4 byte
length of a MSB_U32.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant