Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

ait-pcap help message cleanup #79

Closed
MJJoyce opened this issue May 24, 2018 · 1 comment
Closed

ait-pcap help message cleanup #79

MJJoyce opened this issue May 24, 2018 · 1 comment
Assignees
@MJJoyce
Labels
good first issue Good for newcomers

Comments

@MJJoyce
Copy link
Member

MJJoyce commented May 24, 2018 •
edited
Loading

The start and end time flags' help messages for ait_pcap.py should be updated to be clearer in the format that they expect.

  --stime STIME    Starting time for desired telemetry range in ISO 8601
                   Format "YY-MM-DDThh:mm:SSZ" (default: 1980-01-06 00:00:00)
  --etime ETIME    Ending time for desired telemetry range in ISO 8601 Format
                   "YY-MM-DDThh:mm:SSZ" (default: 2018-05-23 18:54:31.943000)

The "format" specified doesn't match the listed default value. We would update both of these so they match up.

YY-MM-DD-Thh:mm:ssZ -> YYYY-MM-DDThh:mm:ssZ or something similar so that the number of characters matches

The default values should be listed in the same format as specified as well. 1980-01-06 00:00:00 -> 1980-01-06T00:00:00Z
@MJJoyce MJJoyce self-assigned this Jul 2, 2018
@MJJoyce MJJoyce added the good first issue Good for newcomers label Aug 20, 2018
aywaldron added a commit to aywaldron/AIT-Core that referenced this issue Aug 24, 2018
@aywaldron
Issue NASA-AMMOS#79: ait-pcap help message cleanup
3cefa80 
Updated --stime and --etime flag help messages. Updated formats to
YY-MM-DDThh:mm:SSZ, and updated defaults and examples to match this
format. Updated etime default to "current time" rather than an example
time, and relabeled the provided time "example".
aywaldron added a commit to aywaldron/AIT-Core that referenced this issue Aug 24, 2018
@aywaldron
Revert "Issue NASA-AMMOS#79: ait-pcap help message cleanup"
b3e382c 
This reverts commit 3cefa80.
aywaldron added a commit to aywaldron/AIT-Core that referenced this issue Aug 24, 2018
@aywaldron
Issue NASA-AMMOS#79: ait-pcap help message cleanup
037d790 
Updated error message raised during arg processing with new time format.
Updated time formats to refer to seconds as 'ss' instead of 'SS'.
MJJoyce added a commit that referenced this issue Aug 27, 2018
@MJJoyce
Merge pull request #107 from aywaldron/issue-79
ec96fd9 
Issue #79: ait-pcap help message cleanup
@MJJoyce
Copy link
Member Author

MJJoyce commented Aug 27, 2018

Resolved in #107

@MJJoyce MJJoyce closed this as completed Aug 27, 2018
MJJoyce pushed a commit that referenced this issue Sep 4, 2019
@aywaldron @MJJoyce
Issue #79: ait-pcap help message cleanup
a73b00d 
Updated --stime and --etime flag help messages. Updated formats to
YY-MM-DDThh:mm:SSZ, and updated defaults and examples to match this
format. Updated etime default to "current time" rather than an example
time, and relabeled the provided time "example".
MJJoyce pushed a commit that referenced this issue Sep 4, 2019
@aywaldron @MJJoyce
Issue #79: ait-pcap help message cleanup
8df4bd3 
Updated error message raised during arg processing with new time format.
Updated time formats to refer to seconds as 'ss' instead of 'SS'.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@MJJoyce MJJoyce

Labels
good first issue Good for newcomers
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@MJJoyce