[wallet-ext] Workflow run wallet extension #4766
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Jordan-Mysten
changed the title
sblackshear
approved these changes
Sep 25, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
It was noticed that pull-requests from forks don't correctly comment on PRs. This is due to the security of github tokens on forked repos, where they do not have write access to the repo. The solution here is to use some indirection through
workflow_call, which can comment on the PR but importantly does not build the extension (which is potentially a security issue).This is based on guidance from Github: https://securitylab.github.com/research/github-actions-preventing-pwn-requests
Note that this won't work (and therefore we can't test this) until this merges, as
workflow_callonly runs from themainbranch. I tested the best I could locally usingactthough.