wallet-ext: dapp connection status #4707
Conversation
|
💳 Wallet Extension has been built, you can download the packaged extension here: https://github.com/MystenLabs/sui/actions/runs/3083854857#artifacts |
There was a problem hiding this comment.
@pchrysochoidis am i correct to assume this is a work in progress and you intend to add the "Disconnect" ui in a dropdown when the user clicks on "mystenlabs.com" pill in the header? Or is this particular task only about showing the connected/disconnected state and no other interaction?
@mystie711 Yeah this is the first part, I am working on the disconnect part (will open another PR soon). I did it this way to keep the PR relatively small and easier to review! |
| @@ -18,12 +18,16 @@ type AppState = { | |||
| appType: AppType; | |||
| apiEnv: API_ENV; | |||
| navVisible: boolean; | |||
| activeOrigin: string | null; | |||
There was a problem hiding this comment.
This is fine for now, but I wonder if should be some kind of state bag for the sake of easily adding other information beyond the origin and favicon.
There was a problem hiding this comment.
Thanks @Jordan-Mysten, yeah it makes sense, but let's do it when we need to add extra info - to save some time for now
* minimal version only shows the status in the header
pchrysochoidis
force-pushed
the
pc-wallet-ext-4696-apps-connected-indicator
branch
from
2e5bb14 to
16040b9
Compare
pchrysochoidis
deleted the
pc-wallet-ext-4696-apps-connected-indicator
branch
Screen.Recording.2022-09-18.at.22.28.11.mov
part of #4696