-
Notifications
You must be signed in to change notification settings - Fork 11.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[ts-sdk] Update Instructions for using CLI to get compiled modules #4537
Conversation
17811b8
to
f0d42d1
Compare
does |
this looks like essentially dry_run not blocking at all and I can change the CLI to extend |
f0d42d1
to
bb442fa
Compare
Good catch! They are the same thing and I've reverted the Rust changes on this PR |
It's a bit different than dry_run publish tx. This needs to output the compiled modules while the dry_run needs signatures and outputs transaction effects |
bb442fa
to
b32141d
Compare
b32141d
to
4144fa2
Compare
Today we provided a
publish
API in the TS SDK that requires the caller to pass in compiled modules in the right topological order. However, we did not provide any toolings on the TS side for developers to compute the correct topological ordering. We have evaluated a few options to solve this problem:sui client
cli to get the compiled modulesWe've agreed that the first two options have too much engineering overhead, and thus this PR takes the third approach by leveraging the existing
sui move build --dump-bytecode-as-base64
Testing
In nodejs repl