fix(sui-indexer): allow setting --gc-checkpoint-files=false #20783
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Previously I was unable to turn off checkpoint file garbage collection, since the default value was `true`, the `--gc-checkpoint-files` flag didn't expect any values and the default `clap` action was to set the value to `true` when the flag was present. I've tried all of: - `--gc-checkpoint-files 0` - `--gc-checkpoint-files false` - `--gc-checkpoint-files=0` - `--gc-checkpoint-files=false` This changes that so that the `false` value is accepted by the argument. It is based on this [comment](clap-rs/clap#1649 (comment))
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎ 3 Skipped Deployments
|
unmaykr-aftermath
temporarily deployed
to
sui-typescript-aws-kms-test-env
GitHub Actions
Inactive
wlmyng
approved these changes
Jan 6, 2025
This was referenced Feb 10, 2025
Closed
|
this caused a CLI issue reported at #21037 (comment) |
gegaowp
added a commit
that referenced
this pull request
Feb 10, 2025
## Description an issue reported by community #21037 (comment) introduced in #20783 the error was ``` Argument `gc_checkpoint_files`'s selected action SetTrue contradicts `takes_value` note: run with `RUST_BACKTRACE=1` environment variable to display a backtrace ``` ## Test plan ``` DB_POOL_SIZE=10 cargo run --bin sui-indexer -- --db-url "postgres://postgres:postgrespw@localhost:5432/gegao" indexer --remote-store-url https://checkpoints.mainnet.sui.io DB_POOL_SIZE=10 cargo run --bin sui-indexer -- --db-url "postgres://postgres:postgrespw@localhost:5432/gegao" indexer --remote-store-url https://checkpoints.mainnet.sui.io --gc-checkpoint-files DB_POOL_SIZE=10 cargo run --bin sui-indexer -- --db-url "postgres://postgres:postgrespw@localhost:5432/gegao" indexer --remote-store-url https://checkpoints.mainnet.sui.io --gc-checkpoint-files=true DB_POOL_SIZE=10 cargo run --bin sui-indexer -- --db-url "postgres://postgres:postgrespw@localhost:5432/gegao" indexer --remote-store-url https://checkpoints.mainnet.sui.io --gc-checkpoint-files=false DB_POOL_SIZE=10 cargo run --bin sui-indexer -- --db-url "postgres://postgres:postgrespw@localhost:5432/gegao" indexer --remote-store-url https://checkpoints.mainnet.sui.io --gc-checkpoint-files true DB_POOL_SIZE=10 cargo run --bin sui-indexer -- --db-url "postgres://postgres:postgrespw@localhost:5432/gegao" indexer --remote-store-url https://checkpoints.mainnet.sui.io --gc-checkpoint-files false ``` --- ## Release notes Check each box that your changes affect. If none of the boxes relate to your changes, release notes aren't required. For each box you select, include information after the relevant heading that describes the impact of your changes that a user might notice and any actions they must take to implement updates. - [ ] Protocol: - [ ] Nodes (Validators and Full nodes): - [ ] gRPC: - [ ] JSON-RPC: - [ ] GraphQL: - [ ] CLI: - [ ] Rust SDK:
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Previously I was unable to turn off checkpoint file garbage collection,
since the default value was
true, the--gc-checkpoint-filesflagdidn't expect any values and the default
clapaction was to set thevalue to
truewhen the flag was present. I've tried all of:--gc-checkpoint-files 0--gc-checkpoint-files false--gc-checkpoint-files=0--gc-checkpoint-files=falseThis changes that so that the
falsevalue is accepted by the argument, i.e., you can set--gc-checkpoint-files=false. Default behavior when the argument is missing remains the same as before.It is based on this comment
Test plan
How did you test the new or updated feature?
Release notes
Check each box that your changes affect. If none of the boxes relate to your changes, release notes aren't required.
For each box you select, include information after the relevant heading that describes the impact of your changes that a user might notice and any actions they must take to implement updates.