Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added Jpeg-Xs support #19

Merged
merged 2 commits into from
Feb 13, 2025
Merged

Added Jpeg-Xs support #19

merged 2 commits into from
Feb 13, 2025

Conversation

goorjn
Copy link
Contributor

@goorjn goorjn commented Feb 10, 2025

Added Jpeg-Xs (sub)descriptor support.

This requested SMPTE dictionaries to be updated with newer ones containing jpeg-xs data.

There is also a fix proposal for a reported header's size error: header's size should not include index bytes.

@rayden84
Copy link
Collaborator

First of all: thank you for your contribution.
However, there is a disagreement on how to calculate the HeaderbyteCount, please see here: #17. Do you have a documentation for your claim, that it should not include the IndexTableSegment?

For the JPEGXS descriptor: do you have a sample file, so that I can test your work?

Thank you!

@goorjn
Copy link
Contributor Author

goorjn commented Feb 11, 2025

In SMPTE-377m, we have the following:

HeaderByteCount specifies the number of bytes used for the header metadata in this partition. This starts at
the first byte of the key of the primer pack and ends after any trailing KLV fill item which is included within this
HeaderByteCount (see figure 6). The values shall be zero if there is no header metadata in this partition.

image

This shows that HeaderByteCount should not include Index Bytes (and we have another field for IndexByteCount).

I also attach a short jpeg-xs file created using bmx library tools.

@rayden84 rayden84 merged commit f5aa2ac into Myriadbits:master Feb 13, 2025
@rayden84
Copy link
Collaborator

rayden84 commented Feb 13, 2025

Thank you for your contributions, I just merged them. Would you mind passing me a sample of jpg-xs encoded mxf file?

@goorjn
Copy link
Contributor Author

goorjn commented Feb 14, 2025

jpeg-xs.zip
Here is a zipped mxf file, tell me if it works ;-)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants