Skip to content
This repository has been archived by the owner on Sep 8, 2024. It is now read-only.

Commit

Permalink
Add shellcheck step to github actions
Browse files Browse the repository at this point in the history
This runs most of the shellcheck tests. The excludes are:
- SC1091: Avoids errors when shellcheck can't find sourced file
- SC2034: Unused variables, for example colors that aren't used yet
- SC2012: use of ls, from what I can see in our case this is fine (wc -l)
  • Loading branch information
forslund committed Oct 29, 2021
1 parent 7e03548 commit 447023a
Showing 1 changed file with 11 additions and 0 deletions.
11 changes: 11 additions & 0 deletions .github/workflows/unit_test.yml
Original file line number Diff line number Diff line change
Expand Up @@ -66,3 +66,14 @@ jobs:
run: if [[ ${{ matrix.python-version }} == 3.9 ]]; then bash <(curl -s https://codecov.io/bash); fi
env:
CODECOV_TOKEN: ${{ secrets.CODECOV_TOKEN }}
shellcheck:
name: Shellcheck
runs-on: ubuntu-latest
steps:
- uses: actions/checkout@v2
- name: Shell check mycroft tools
uses: ludeeus/action-shellcheck@master
env:
SHELLCHECK_OPTS: -x --exclude SC2034 --exclude SC2012 --exclude SC1091
with:
scandir: ./bin

0 comments on commit 447023a

Please sign in to comment.