Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

bug/convert-null-to-object #1773

Merged
merged 4 commits into from
Dec 19, 2019
Merged

bug/convert-null-to-object #1773

merged 4 commits into from
Dec 19, 2019

Conversation

gamalielhere
Copy link
Contributor

@gamalielhere gamalielhere commented Dec 19, 2019

Bug

  • Updated CHANGELOG.md
  • Add PR label

Might be a fix to that intermittent error after logging out

@gamalielhere gamalielhere added Bug Issues identified. Should be re-labeled to Fatal, or won't fix based on that Ready Tag for when a PR is ready to merge labels Dec 19, 2019
@gamalielhere gamalielhere changed the title Might be a fix to that intermittent error bug/convert-null-to-object Dec 19, 2019
@codecov
Copy link

codecov bot commented Dec 19, 2019

Codecov Report

Merging #1773 into develop will decrease coverage by <.01%.
The diff coverage is n/a.

Impacted file tree graph

@@             Coverage Diff             @@
##           develop    #1773      +/-   ##
===========================================
- Coverage    13.73%   13.72%   -0.01%     
===========================================
  Files          429      429              
  Lines        14257    14263       +6     
  Branches      2615     2617       +2     
===========================================
  Hits          1958     1958              
- Misses       11496    11500       +4     
- Partials       803      805       +2
Impacted Files Coverage Δ
src/layouts/InterfaceLayout/InterfaceLayout.vue 0% <ø> (ø) ⬆️
src/directives/AddrResolver.js 0.94% <0%> (-0.06%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update ca83780...1f163d1. Read the comment docs.

@kvhnuke kvhnuke merged commit e163393 into develop Dec 19, 2019
@kvhnuke kvhnuke deleted the bug/convert-null-to-object branch December 19, 2019 03:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Bug Issues identified. Should be re-labeled to Fatal, or won't fix based on that Ready Tag for when a PR is ready to merge
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants