Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add in TOS link #1704

Merged
merged 5 commits into from
Dec 3, 2019
Merged

Add in TOS link #1704

merged 5 commits into from
Dec 3, 2019

Conversation

gesseekur
Copy link
Contributor

@gesseekur gesseekur commented Dec 3, 2019 •
edited by gamalielhere
Loading

Bug

  • Updated CHANGELOG.md
  • Add PR label
  • No hard-coded strings

@gesseekur gesseekur added Bug Issues identified. Should be re-labeled to Fatal, or won't fix based on that Ready Tag for when a PR is ready to merge labels Dec 3, 2019
@codecov
Copy link

codecov bot commented Dec 3, 2019

Codecov Report

Merging #1704 into master will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master    #1704   +/-   ##
=======================================
  Coverage   14.04%   14.04%           
=======================================
  Files         429      429           
  Lines       14415    14415           
  Branches     2630     2630           
=======================================
  Hits         2024     2024           
  Misses      11612    11612           
  Partials      779      779

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update a6847ef...29bcba2. Read the comment docs.

@gamalielhere gamalielhere changed the base branch from master to bug/resolver-fix December 3, 2019 22:01
@gamalielhere gamalielhere merged commit 5090eef into bug/resolver-fix Dec 3, 2019
@gamalielhere gamalielhere deleted the bug/translations branch December 3, 2019 22:01
@gamalielhere gamalielhere restored the bug/translations branch December 3, 2019 22:01
@gamalielhere gamalielhere deleted the bug/translations branch December 3, 2019 22:01
@snyk-bot snyk-bot mentioned this pull request Mar 23, 2023
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@gamalielhere gamalielhere gamalielhere approved these changes

@kvhnuke kvhnuke Awaiting requested review from kvhnuke

@SteveMieskoski SteveMieskoski Awaiting requested review from SteveMieskoski

Assignees
No one assigned
Labels
Bug Issues identified. Should be re-labeled to Fatal, or won't fix based on that Ready Tag for when a PR is ready to merge
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@gesseekur @gamalielhere @mew-bot