Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove Ethers RSK hack #3808

Merged
merged 1 commit into from
Feb 2, 2021
Merged

Remove Ethers RSK hack #3808

merged 1 commit into from
Feb 2, 2021

Conversation

FrederikBolding
Copy link
Collaborator

No description provided.

@FrederikBolding FrederikBolding temporarily deployed to STAGING February 2, 2021 11:15 Inactive
@FrederikBolding
Copy link
Collaborator Author

@mycrypto-bot
Copy link
Collaborator

Staging build: MyCryptoBuilds

@codecov
Copy link

codecov bot commented Feb 2, 2021

Codecov Report

Merging #3808 (1589e5d) into master (e64f422) will increase coverage by 0.01%.
The diff coverage is 0.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #3808      +/-   ##
==========================================
+ Coverage   55.93%   55.95%   +0.01%     
==========================================
  Files         618      618              
  Lines       12935    12931       -4     
  Branches     3192     3192              
==========================================
  Hits         7235     7235              
+ Misses       5680     5676       -4     
  Partials       20       20              
Impacted Files Coverage Δ
src/services/EthService/network/providerHandler.ts 61.29% <0.00%> (+3.71%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update e64f422...1589e5d. Read the comment docs.

@vilsbole
Copy link
Contributor

vilsbole commented Feb 2, 2021

Explained by ethers-io/ethers.js#1251

Copy link
Contributor

@vilsbole vilsbole left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm;

@vilsbole vilsbole merged commit c6e292a into master Feb 2, 2021
@vilsbole vilsbole deleted the fb/remove-ethers-rsk-hack branch February 2, 2021 12:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants