Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

【优化】MultiNodeQueryHandler，MultiNodeHandler代码优化 #2487

Closed
funnyAnt opened this issue Jun 1, 2020 · 1 comment
Closed

【优化】MultiNodeQueryHandler，MultiNodeHandler代码优化 #2487

funnyAnt opened this issue Jun 1, 2020 · 1 comment

Comments

@funnyAnt
Copy link
Collaborator

funnyAnt commented Jun 1, 2020 •
edited
Loading

MultiNodeQueryHandler，MultiNodeHandler代码优化
@funnyAnt funnyAnt changed the title 【故障】MultiNodeQueryHandler多节点运行时，偶尔发现不返回结果集，nodeCount为负数 【优化】MultiNodeQueryHandler，MultiNodeHandler代码优化 Jun 1, 2020
@funnyAnt
Copy link
Collaborator Author

funnyAnt commented Jun 1, 2020

优化点：

  • 1、decrementCountBy(int finished) 没有减去finished，无论finished传入什么值，都是-1
  • 2、MultiNodeQueryHandler里面定义了lock锁，其父类MultiNodeHandler也定义了lock锁，容易混淆，去掉MultiNodeQueryHandler里面的lock锁

junwen12221 added a commit that referenced this issue Jun 2, 2020
@junwen12221
Merge pull request #2488 from funnyAnt/Mycat-server-1.6.76-subtables
df1bb04 
#2487【优化】MultiNodeQueryHandler，MultiNodeHandler代码优化
@junwen12221 junwen12221 mentioned this issue Dec 31, 2020
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@funnyAnt