This repository was archived by the owner on Feb 3, 2025. It is now read-only.
Potential fixes for MutinyChain #199
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Comment on lines
+348
to
+351
| let mut locked_watched_transactions = self.watched_transactions.lock().unwrap(); | ||
| for txid in to_watch { | ||
| locked_watched_transactions.insert(txid); | ||
| } |
There was a problem hiding this comment.
Should we .clear() first or do we really need to just be inserting new ones to add to it? The old behavior did a replacement.
There was a problem hiding this comment.
I think we are supposed to add, that's what is done in the ldk PR
AnthonyRonning
approved these changes
Dec 12, 2022
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Copies some changes made in lightningdevkit/rust-lightning#1870
We still can't directly copy paste as we need some deps to update