Update to latest upstream for ctrl support on macos #10
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The changes to QMutex were actually introduced in Qt 5.14 and not 6.0 and some versions of Qt 5.15 are now throwing depracation warnings if they encounter the older form. Signed-off-by: Stephen Lyons <[email protected]>
keneanung
approved these changes
Oct 9, 2024
SlySven
reviewed
Oct 9, 2024
| @@ -25,7 +25,9 @@ void FactoryKeyMap::fill( TextEditorKeyMap* km ) | |||
| add( "goto_next_word", "move_to_next_word" ); | |||
| add( "goto_prev_word", "move_to_previous_word" ); | |||
| add( "goto_bol", "move_to_start_of_line" ); | |||
| add( "goto_bol", "move_to_start_of_block"); | |||
There was a problem hiding this comment.
Not sure what effect this and the change two lines down do - but is it correct for the two new entries to have the same keys as the adjacent ones - or is it that what ever a block is this is treating it the same as a line? 😟
There was a problem hiding this comment.
I think you missed #9, have a look there for the information.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.