Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Genetics Nerf; Butchers Space Adaption Into a Two Gene Combo (Plus a New Gene!) #91

Merged
merged 12 commits into from
Sep 22, 2021

Conversation

Jolly-66
Copy link
Contributor

@Jolly-66 Jolly-66 commented Sep 18, 2021

I really fucking hate genetics as it stands, and all of science for that matter, so this is my band-aid """fix""" to nerfing it.

Space adaption is NO LONGER a printable mutation, instead its a combo of two new genes.

FRIGID IMMUNITY
Cold resistance. 10 instability.
You will take x2 more heat related damage.

SWEALTERING IMMUNITY
Heat resistance. 10 instability.
You will now take x2 more cold related damage.

VACUUM ADAPTATION
Vacuum resistance. 30 instability.
You will now take x2.5 more oxy loss related damage (non suffocation related).
You will now have a x2.25 pain modifier.

Vacuum Adaptation + Frigid Immunity = Space adaptation.

A SMALL THING TO NOTE:
For some reason the "halo" isn't appearing when you combo these genes, will look into it sometime.

@Jolly-66 Jolly-66 added the Adjustment Tweaking something to be better, maybe label Sep 18, 2021
@CRITAWAKETS
Copy link
Contributor

CRITAWAKETS commented Sep 19, 2021

Why are we even keeping space adaptation if cold resistance + vacuum resistance does the same thing?

Also, cold resistance and vacuum resistance should have their instability values swapped. You encounter cold a lot more than vacuum and its generally more deadly (especially to them lizerds and slimeys). I'd recommend changing it though so that cold resistance is 20 and vacuum is 10, unless you want to up the instability cost.

Also this really isnt a nerf especially since heat resistance is a thing now. If anything, its a buff.

@Jolly-66
Copy link
Contributor Author

Jolly-66 commented Sep 19, 2021

Also, cold resistance and vacuum resistance should have their instability values swapped. You encounter cold a lot more than vacuum and its generally more deadly (especially to them lizerds and slimeys). I'd recommend changing it though so that cold resistance is 20 and vacuum is 10, unless you want to up the instability cost.

Should we just bump both temps to 15-20 with vacuum 25-30?

@MrMelbert

Copy link
Owner

@MrMelbert MrMelbert left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

In my opinion:

@MrMelbert
Copy link
Owner

I'm fine with it being split, every mutation balances genetics slightly more

For number references:

Lizards have a 1.5x cold modifier and 0.67 heat modifier.
Plasmamen and podpeople have a 1.5x heat modifier.

Comment on lines 16 to 22
owner.physiology.cold_mod *= 2

/datum/mutation/human/cold_adaptation/on_losing(mob/living/carbon/human/owner)
if(..())
return
REMOVE_TRAIT(owner, TRAIT_RESISTCOLD, GENETIC_MUTATION)
owner.physiology.heat_mod /= 2
Copy link
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

cold mod *=2
heat mod /=2

🤔

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

when melbert reviews the same file twice

sus

Copy link
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

i didn't review the same file twice
i reviewed heat adaptation to say "you got it backwards" and cold adaptation to say "you copypasted wrong"

Copy link
Owner

@MrMelbert MrMelbert left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

mutations / modifiers could use some numbers tweaks still but I think it's fine now

@Jolly-66
Copy link
Contributor Author

I'm gonna figure out the halo bullshit later, probably gonna do a hack fix but its whatever.

@Jolly-66 Jolly-66 merged commit 2391b98 into master Sep 22, 2021
@Jolly-66 Jolly-66 deleted the Fuck-Genetics branch September 22, 2021 00:11
CRITAWAKETS pushed a commit to CRITAWAKETS/JollyStationCode that referenced this pull request Sep 23, 2021
CRITAWAKETS pushed a commit to CRITAWAKETS/JollyStationCode that referenced this pull request Sep 23, 2021
CRITAWAKETS pushed a commit to CRITAWAKETS/JollyStationCode that referenced this pull request Oct 7, 2021
CRITAWAKETS pushed a commit to CRITAWAKETS/JollyStationCode that referenced this pull request Oct 9, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Adjustment Tweaking something to be better, maybe
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants