refacto(ocio): config overhaul #35
Draft
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
the plan is to have multiple config variants for users,
reduce the build script by splitting "utility" code to different modules
- this reduce code duplication. - the initial need is that we want each `view` to have its own colorspaces defined, for software that don't expose `views` in export options. - this mean we need to build a matrix of display colorspaces x image renderings x looks - we call those colorspaces "image colorspaces" as they produce a viewable image. - we also renamed other colorspaces to have a more consistent and subjectively better naming convention
this is a breaking change fully changing the look over the previous version. this is the result of multiple month of research based on other people work around AGX and image rendering. the prototype of the rendering was achieved in nuke for fast iteration. The new rendering: - assume a BT.2020 working space - use a double inset which wrap a new "luminance compensation" algorithm (whatever that means) - use the outset concept
renamed some colorspaces names for better readability
major change on ocio side
TODOI need to fix the compatibility with Redshift again. It seems some of the changes break it again. I may need to create a custom variant for redshift. |
…riant redshift is very annoying as its require to "find" some specific colorspaces to work but there is no documentation on that discovery process. see https://redshift.maxon.net/topic/44651/ocio-colorspace-discovering-process-is-too-obscure
adding the to the pyproject prevented them from being "live loaded" and required a rebuild on every modification
which does actually not do diff yet and just generates images
easier to compare mosaic images between versions that change colorspaces names/order in config
switch to a fully automated process relying on the OCIO configs and oiiotool for image processing.
to avoid overlap on ACES images
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Bif refactoring of the config
Changelog
Added
BT.2020colorspace, with linear transfer-functionChanged
familyfor "view" colorspaces{gamut name}-{transfer function}(-{whitepoint})soLinear sRGBbecomesRGB-linearChore
<View>and their colorspaces (Image Colorspaces)