Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

✨ Replace loop icon png with custom SF Symbol #68

Merged
merged 2 commits into from
Oct 27, 2023
Merged

✨ Replace loop icon png with custom SF Symbol #68

merged 2 commits into from
Oct 27, 2023

Conversation

caocanx
Copy link
Contributor

@caocanx caocanx commented Oct 27, 2023

Make the icon looks smoother. It created base on the circle.circle in SF Symbols 5.

Slide 16_9 - 1

@MrKai77 MrKai77 self-requested a review October 27, 2023 13:56
@MrKai77 MrKai77 assigned caocanx and MrKai77 and unassigned MrKai77 Oct 27, 2023
@MrKai77
Copy link
Owner

MrKai77 commented Oct 27, 2023

Looks good! Just tested this locally and the icon in the settings window looks so much smoother!
My only piece of feedback is that the menubar icon looks a little "heavy". Would you be able to make it look lighter in the menubar? (It looks perfect in the settings window)
Adding .fontWeight(.light) should be sufficient :)
Once that is done, this PR should be ready for merge!

MrKai77
MrKai77 reviewed Oct 27, 2023
View reviewed changes
Loop/MenuBar/MenuBarIconView.swift
@@ -10,7 +10,10 @@ import SwiftUI
struct MenuBarIconView: View {
@State var rotationAngle: Double = 0.0
var body: some View {
Image(.menubarIcon)
Image("loop")
Copy link
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Add .fontWeight(.light)

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Very good advice, I added it.

MrKai77
MrKai77 approved these changes Oct 27, 2023
View reviewed changes
Copy link
Owner

@MrKai77 MrKai77 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good!

@MrKai77 MrKai77 merged commit ed2219e into MrKai77:develop Oct 27, 2023
@MrKai77 MrKai77 changed the title Replace loop icon png with custom SF Symbol ✨ Replace loop icon png with custom SF Symbol Oct 28, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@MrKai77 MrKai77 MrKai77 approved these changes

Assignees

@caocanx caocanx

Labels
Feature
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@caocanx @MrKai77