🐞 Fix cycle actions not working #595
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I encountered this exact issue previously as well! I ultimately removed the screen switching from the Left/Right cycles. Will test if it is now working with this PR. |
|
Just tested that the issue is reproducible on 1.2.0 (1356) and fixed by this PR. |
|
@ShawnZhong awesome thank you so much for testing!! |
MrKai77
deleted the
mrkai77/loop-647-allow-the-window-position-commands-to-move-to-next-screen
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Not sure how I didn't catch this bug earlier :/
This fixes a bug where cycle keybinds stop advancing after switching screens. Please test before approving, since again, I find it really odd that this bug originally even made it to production.