Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

🐛 Can‘t restore window frame on drag #219

Closed
2 tasks done
acocoadog opened this issue Feb 17, 2024 · 4 comments · Fixed by #221
Closed
2 tasks done

🐛 Can‘t restore window frame on drag #219

acocoadog opened this issue Feb 17, 2024 · 4 comments · Fixed by #221
Assignees
Labels

Comments

@acocoadog
Copy link

Bug Description

If the window to be restored exceeds the boundary of the screen, it will cause the window to not be restored.

Steps To Reproduce

  1. Adjust the window to maximum
    2.Use Loop to adjust the window to Right Half
  2. Drag the window to the left

Expected Behavior

In fact, many similar app have this problem. Among them, Switch avoids this problem. When dragging the window with the mouse, firstly move the window to the appropriate position according to the expected size of the recovery to ensure that the window does not touch the screen boundary after it is restored, and then restore the window size.

Actual Behavior

As described in the description, when the window restoring, it may be limited by the screen boundary and therefore cannot restore its original size.

Screenshots

No response

MacOS Version

14.3

Loop Version

Version 1.0.0-beta.14 (644)

Additional Context

No response

Final Checks

  • My issue title is descriptive
  • This is a single bug (multiple bugs should be reported individually)
@acocoadog acocoadog added the Bug label Feb 17, 2024
@MrKai77
Copy link
Owner

MrKai77 commented Feb 18, 2024

Interesting, I never noticed this! Will fix!

@MrKai77 MrKai77 changed the title 🐛Can‘t restore window frame on drag 🐛 Can‘t restore window frame on drag Feb 18, 2024
@MrKai77 MrKai77 self-assigned this Feb 18, 2024
@acocoadog
Copy link
Author

Thank you very much! In fact, few app have noticed this problem. In addition, in the scenario I described in "Steps To Reproduce", if we drag the window to the right (that is, the direction of the edge of the screen), then this problem will not occur, I really do not know why.
Also attached is a video showing how Switch solves this problem. I hope it will be helpful to you!
备忘录截屏2024-02-18 at 10 00 55

@MrKai77
Copy link
Owner

MrKai77 commented Feb 18, 2024

Let me know how this is!
Loop.zip

@acocoadog
Copy link
Author

Let me know how this is! Loop.zip

That's so cool! The problem seems to have been solved.

MrKai77 added a commit that referenced this issue Feb 18, 2024
…-on-drag`

🐛 #219 Can‘t restore window frame on drag
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants