Link/Node: noop onClick/Hover if readonly #45
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
In MrBlenny#43 links and nodes were clickable and deletable. This commit disables the onClick for Nodes if config.readonly is set to true and disables onClick and Hover for Links. It also updates the OnLinkClick interface to point to IOnLinkClick. Previously it pointed to IOnLinkMouseLeave which shares the same interface but was likely a copy paste error.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In #43 links and
nodes were clickable and deletable. This commit disables the onClick for
Nodes if config.readonly is set to true and disables onClick and Hover
for Links.
It also updates the OnLinkClick interface to point to IOnLinkClick.
Previously it pointed to IOnLinkMouseLeave which shares the same
interface but was likely a copy paste error.